Skip to content

Outbound Checklist Code Review #3

Description

@zionmich

I need reviewers for this section of the checklist.md
—————————————————————
Code Review

The existing codebase should be given a one time, top-to-bottom code quality and security vulnerability review by two (or more) engineers who have written production code within the past two years, in the languages used in the project. Engineers should review credential management practices with the development team to ensure that any keys, passwords, or other sensitive configurations are not checked into source code or in the git history.

The engineers can be federal government employees or trusted partners from outside the agency from other contracts, or from independent testing contracts. Their names, organizations, comments and approval/disapproval on the overall codebase should be tracked in this document.

To provide independent review, the engineers should not have been involved in the development of the software product. This includes engineers who wrote part of the software or who directly provided technical direction and oversight in the creation of the software.

As part of the code review, engineers should reference modern listings of the most significant software security vulnerabilities. For instance, an acceptable description would be that the engineers showed how they used automated tools and manual review to check each item in OWASP's current 10 Most Critical Web Application Security Risks.

Results

Insert Review Here

—————————————————————
I also need sign-offs here:

Reviewer Organization Reviewer Names Reviewer’s Recommendation
Code Reviewer 's Reccommendation CODE REVIEWER 1 CODE REVIEWER 2 CODE REVIEWER 3 [Approved/Needs Approval] [Approved/Needs Approval] [Approved/Needs Approval]
ISSO ISSO REVIEWER [Approved/Needs Approval]
ISG Technical Approval ISG REVIEWER [Approved/Needs Approval]
Business Owner(s) BUSINESS OWNER 1 BUSINESS OWNER 2 [Approved/Needs Approval] [Approved/Needs Approval]

—————————————————————

In order to complete the review please confirm that you can

  1. install the necessary requirements from the requirements.txt
  2. run the makeYaml.py successfully
  3. run the makeCodebook.py successfully
  4. run the makeAll.py successfully
  5. ensure that as a new user the read me is clear and easy to follow, successfully instructing you how to run the scripts above

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions