Skip to content

MCP: bn_function_prototype_set does nothing #8351

Description

@bdash

Version and Platform (required):

  • Binary Ninja Version: 5.4.10157-dev Ultimate, 5b89dad7
  • OS: macOS 26.5.2
  • CPU Architecture: arm64

Bug Description:
Attempting to use bn_function_prototype_set always results in a response with changed=false, no matter the differences between the old prototype and new. The new prototype does not take.

This appears to be a result of the logic setting the user type, then immediately reading back the function's type to determine if the new state is different than the old state. Since the function's type only updates when analysis commits, it always sees the original type again, decides nothing has changed, and rolls back the undo action.

Metadata

Metadata

Assignees

Labels

Component: MCPEffort: LowIssues require < 1 week of workImpact: MediumIssue is impactful with a bad, or no, workaround

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions