IPv6 support for logging.handlers

[cblp]

BPO	14855
Nosy	@loewis, @gpshead, @vsajip, @pitrou
Files	mywork.patch: Patch that adds IPv6 support to logging.handlers mywork2.patch: socket.create_connection supports UDP; DatagramHandler supports IPv6

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2012-05-19.09:49:33.079>
labels = ['type-feature', 'library']
title = 'IPv6 support for logging.handlers'
updated_at = <Date 2015-02-26.16:51:07.647>
user = 'https://bugs.python.org/cblp'

bugs.python.org fields:

activity = <Date 2015-02-26.16:51:07.647>
actor = 'Thomas Bartelmess'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2012-05-19.09:49:33.079>
creator = 'cblp'
dependencies = []
files = ['25635', '25680']
hgrepos = []
issue_num = 14855
keywords = ['patch']
message_count = 13.0
messages = ['161101', '161102', '161103', '161104', '161106', '161127', '161128', '161132', '161136', '161408', '161410', '161492', '236687']
nosy_count = 6.0
nosy_names = ['loewis', 'gregory.p.smith', 'vinay.sajip', 'pitrou', 'cblp', 'Thomas Bartelmess']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14855'
versions = ['Python 3.3']

Linked PRs

• gh-59060: Support IPv6 in logging.handlers.DatagramHandler #154496

[cblp]

IPv4 operations may fail on IPv6 systems, and vice versa. So we have to create sockets with the proper address family.

Maybe this behaviour could be incapsulated in socket object, but didn't find a good way to do it.

No documentation changed, because I just eliminate lack of implementation of already documented feature.

Please help to write tests.

I worked on the 3.2 branch, because the default branch has broken test_logging.

[cblp]

More correct description: IPv4 operations may fail on IPv6 systems, and vice versa; so we have to detect the proper address family before creating a socket.

[pitrou]

For TCP, socket.create_connection() is your friend. For UDP I'm not sure, but adding a helper to the socket module might also be a good idea.

[pitrou]

The Linux getaddrinfo() man page has an UDP client example which uses connect() to decide whether the target address is valid or not.

[loewis]

Apparently, connecting the socket is better because some systems (BSDs in particular) only report ICMP errors to connected UDP sockets. The Linux man page claims that this reporting is necessary regardless of whether the socket is connected.

I wonder what will happen under this patch if the server has both v4 and v6 connectivity, and the client supports v6, but has no connectivity (other than, say, on the local link).

[cblp]

On my computer, connect() on a UDP socket always finishes successfully. What's wrong?

I tried that C example from man getaddrinfo(3).

[pitrou]

On my computer, connect() on a UDP socket always finishes
successfully. What's wrong?

Nothing wrong I guess, since connect() on an UDP socket doesn't actually
do anything, network-wise (UDP being an unconnected protocol).

[loewis]

On my computer, connect() on a UDP socket always finishes
successfully. What's wrong?

Nothing is wrong. UDP is connection-less, so connect() is a no-op,
except that it remembers the address so you can use send() instead
of sendto(). Any errors due to non-reachability will only happen when
you actually try to send.

[vsajip]

I worked on the 3.2 branch, because the default branch has broken
test_logging.

What breakage are you referring to? There's a race condition test that fails on Windows sometimes, but that's on the 2.7 branch. Apart from that, I don't know what breakage you're referring to, so please elaborate.

[cblp]

Can the datagramHandler.host change during execution? If so, the address family of the socket can change. So, we should create a socket for every new message. Check my patch #2.

Also I extended socket.create_connection to support UDP.

[cblp]

test_logging is not broken, but just fails.

test test_logging failed -- Traceback (most recent call last):
  File "/home/cblp/my/cpython_default/Lib/test/test_logging.py", line 2903, in test_time
    self.assertEqual(f.formatTime(r), '1993-04-21 08:03:00,123')
AssertionError: '1993-04-21 09:03:00,123' != '1993-04-21 08:03:00,123'
- 1993-04-21 09:03:00,123
?             ^
+ 1993-04-21 08:03:00,123
?             ^

Or should it go to the separate ticket?

[vsajip]

Or should it go to the separate ticket?

Yes, please.

[ThomasBartelmess]

The datagram handler seems still not useable with IPv6 in Python 3.4. Is this patch still under consideration ?