Remove if self.attention != "dot_product": restriction for mla_qk_head_chunk_size in types.py - #4666
Open
copybara-service[bot] wants to merge 1 commit into
Open
Remove if self.attention != "dot_product": restriction for mla_qk_head_chunk_size in types.py#4666copybara-service[bot] wants to merge 1 commit into
if self.attention != "dot_product": restriction for mla_qk_head_chunk_size in types.py#4666copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
A9isha,
Lumosis,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
gpolovets1,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
jrplatin,
khatwanimohit,
mailvijayasingh,
michelle-yooh,
mitalisi,
parambole,
patemotter,
richjames0,
shralex,
shuningjin,
suexu1025,
vipannalla and
xibinliu
as code owners
July 29, 2026 10:22
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
copybara-service
Bot
force-pushed
the
test_955775132
branch
from
July 29, 2026 23:17
a0bbb58 to
b64a48c
Compare
copybara-service
Bot
changed the title
if self.attention != "dot_product": restriction for mla_qk_head_chunk_size in types.py
copybara-service
Bot
force-pushed
the
test_955775132
branch
4 times, most recently
from
July 30, 2026 01:11
b06695f to
1ef1545
Compare
copybara-service
Bot
force-pushed
the
test_955775132
branch
3 times, most recently
from
July 30, 2026 02:27
666c5f2 to
b0143a4
Compare
…head_chunk_size` in `types.py` Allow `mla_qk_head_chunk_size` to be used with attention types other than dot_product attention. PiperOrigin-RevId: 955775132
copybara-service
Bot
force-pushed
the
test_955775132
branch
from
July 30, 2026 04:03
b0143a4 to
b4169d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
if self.attention != "dot_product":restriction formla_qk_head_chunk_sizeintypes.pyAllow
mla_qk_head_chunk_sizeto be used with attention types other than dot_product attention.