Multi Install - #127
Conversation
…stall" and "Uninstall" buttons to those lists, and therefore the mod browser no longer works.
…ng to selected mods.
…rently selected for addition/removal
…heir parameters and usages.
…al from browser. updated main modmenu button titles to match the mod browser's functionality.
| :returns: done_flag if reload_script is False, else None. done_flag is a threading.Event which becomes set once the mod is installed. note that this return value can end interactions. | ||
| """ | ||
| if reload_script is None: | ||
| reload_script = show_status_screen |
There was a problem hiding this comment.
This doesn't make sense - show_status_screen is being used to restart python later
There was a problem hiding this comment.
I don't quite follow why it doesn't? it's default allows for two main uses:
- when
show_status_screen==False, then the mod application is done silently in the background, and therefore it shouldn't restart the game when done as it will be without warning. - when
show_status_screen==True, then then the mod application takes over the screen, as it is the main thing To Be Done. as such, it is allowed (and encouraged) to restart, as mod changes generally warrant that.
Explicitly settingreload_scriptcould be done for more unusual uses, though I'm not sure about their advisability.
There was a problem hiding this comment.
What was confusing to me here was that it wasn't obvious what type show_status_screen was. Though given we're calling this function in only a few places, do you think it would make sense here to also pass in reload_script=True whenever we want to show the status screen?
There was a problem hiding this comment.
Oh, I see that I didn't describe it well in the comment (as in, only described the True case and not the False case).
As for explicitly passing reload_script=True, I guess that would be clearer... I'll be on that
2 participants
Creates functionality to add and remove multiple mods in a single session of the in-game mod browser, improving usability and saving game restarts.
Mods may be selected for installation/removal by the existing install/uninstall buttons in the mod browser, or toggled by right click on their corresponding button in the mod list.
The selected mod lists (for addition and removal) are viewable in the new apply status screen, which allows removal of mods from these lists.
Once applied, all selected mods are either installed or uninstalled, with installations coming first.