Skip to content

[O2B-1602] Shared BeamTypesDto should return split input rather than simply validation - #2202

Merged
graduta merged 20 commits into
mainfrom
feature/O2B-1602-add-pdp-beam-type-filter
Aug 3, 2026
Merged

[O2B-1602] Shared BeamTypesDto should return split input rather than simply validation#2202
graduta merged 20 commits into
mainfrom
feature/O2B-1602-add-pdp-beam-type-filter

Conversation

@graduta

@graduta graduta commented Jul 31, 2026

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • BeamTypesFilterDto will now as per the convention return an array of beam types rather than a string which then every usecase (GetAllLhcFills and GetAllRuns) have to split the input
  • tests adapted accordingly

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.17%. Comparing base (240113f) to head (37f8eca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2202      +/-   ##
==========================================
- Coverage   46.20%   46.17%   -0.03%     
==========================================
  Files        1039     1038       -1     
  Lines       17131    17120      -11     
  Branches     3123     3121       -2     
==========================================
- Hits         7915     7905      -10     
+ Misses       9216     9215       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta graduta changed the title [O2B-1602] Add option to filter by pdp beam type [O2B-1602] Shared BeamTypesDto should return split input rather than simply validation Jul 31, 2026
@graduta
graduta marked this pull request as ready for review July 31, 2026 11:39
@graduta
graduta requested a review from isaachilly as a code owner July 31, 2026 11:39
Comment thread lib/domain/dtos/common/BeamTypeDto.js
Comment thread lib/domain/dtos/common/BeamTypeDto.js Outdated
Comment thread lib/domain/dtos/common/BeamTypeDto.js
@graduta
graduta requested a review from isaachilly August 1, 2026 11:02
@graduta
graduta force-pushed the feature/O2B-1602-add-pdp-beam-type-filter branch from 11a0a33 to f051789 Compare August 3, 2026 07:21
@graduta
graduta merged commit 9d619bb into main Aug 3, 2026
23 of 24 checks passed
@graduta
graduta deleted the feature/O2B-1602-add-pdp-beam-type-filter branch August 3, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants