fix(#512): harden OAuth document recovery lifecycle - #528
Merged
Conversation
BorisTyshkevich
marked this pull request as ready for review
July 28, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #527 addressing the post-merge recovery lifecycle review.
Root cause
The original retry gate treated clean dirty flags as proof that the live document session had not changed, workspace mismatch was classified as terminal, and redirect rollback owned only the three legacy PKCE attempt keys. Those boundaries were narrower than the full recovery/OAuth transaction.
User impact
Newer saved or reorganized work is no longer replaced automatically by a stale checkpoint. Switching workspaces no longer deletes another workspace recovery copy. Failed redirect assignment restores the complete prior OAuth/recovery transaction.
Validation
npx tsc --noEmitnpm test— 6,426 tests passed; 100% statements/lines and repository coverage gates passednpm run build