chore: add @meetamitbhatia to CODEOWNERS alongside @j7nw4r - #7265
Open
j7nw4r wants to merge 1 commit into
Open
Conversation
Amit Bhatia joins the messaging team. This gives him the same CODEOWNERS entries that @j7nw4r has, so he gets review requests on the same paths.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 7 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 7 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s CODEOWNERS configuration to ensure @meetamitbhatia is requested as a reviewer for the same Event Hubs (messaging) paths already owned by @j7nw4r, reducing review latency for changes under /sdk/eventhubs/.
Changes:
- Added
@meetamitbhatiato the/sdk/eventhubs/CODEOWNERS entry alongside the existing individual owners. - Updated the corresponding
%Event Hubs# ServiceOwners:comment to include@meetamitbhatia.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@meetamitbhatia (Amit Bhatia) is not in the CODEOWNERS file. He works on the messaging libraries and must get review requests on the same paths as @j7nw4r.
Motivation
@meetamitbhatia joined the messaging team. Without a CODEOWNERS entry, GitHub does not add him to pull requests that touch the messaging paths. The team then loses a reviewer, and review latency goes up.
Changes
This change adds
@meetamitbhatianext to@j7nw4ron every line that already lists@j7nw4r. It changes 1 owner path and 1ServiceOwnerscomment. It removes no owner and adds no new path.Owner paths:
/sdk/eventhubs/Validation
@meetamitbhatia is a member of the
Azureorganization, so the CODEOWNERS linter can resolve the handle.