Conversation
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
a few specific questions about the changes to how this is initialized, and a question about reusing existing HEAD checks from BerkeleyLibrary::Util.
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Would love to discuss more about the benefits/drawbacks of the custom head check vs the one in Util.
Also, we should dig in to that Docker failure and fix it properly.
|
|
||
| # Check the Solr connection | ||
| # Requires the ping handler on the solr core (<core>/admin/ping). | ||
| solr_url = ENV['SOLR_URL'].presence |
There was a problem hiding this comment.
To be sure, this means we no longer support setting SOLR_URL as an env var? I was using this in development for testing things, actually, but that is not such a big deal if so. I can just change to using the app configuration.
| bash \ | ||
| curl \ | ||
| default-jre-headless \ | ||
| ca-certificates \ | ||
| libpq-dev \ | ||
| libvips42 && \ | ||
| bash \ | ||
| curl \ | ||
| default-jre-headless \ | ||
| ca-certificates \ | ||
| libpq-dev \ | ||
| libvips42 && \ |
There was a problem hiding this comment.
Not a big fan of this, it makes it harder to tell where the package list ends and the next command begins.
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
r+wc. one minor change given the switch to the shared check.
Co-authored-by: Anna Wilcox <AWilcox@Wilcox-Tech.com>
3 participants
skip_link_componenterror.