Playground: single canonical UI at /playground/, no /web/ subdir#1032
Merged
Conversation
Before: playground/web/{index.html,app.js,style.css} were the
canonical UI, served by the playground at /ui/. To make GitHub
Pages serve the same UI at https://benchmark.clickhouse.com/
playground/ (index.html precedence over auto-rendered README.md),
we needed EITHER a duplicate copy of index.html at playground/
OR symlinks — GitHub Pages doesn't reliably follow symlinks and
duplication rots.
Move index.html + app.js + style.css to playground/ (the parent).
The relative refs `<link href="style.css">` / `<script src="app.js">`
already resolve correctly at both /playground/ (GitHub Pages) and
/ui/ (playground server, which the server code now points at the
new location).
Server change: the /ui/ static routes now explicitly whitelist
index.html + app.js + style.css so README.md / INSTALL.md / docs/
under playground/ don't accidentally leak at /ui/README.md etc.
The app.js API-base fallback (previous commit) already handles
cross-origin fetches when loaded from benchmark.clickhouse.com or
any other host.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: playground/web/{index.html,app.js,style.css} were the canonical UI, served by the playground at /ui/. To make GitHub Pages serve the same UI at https://benchmark.clickhouse.com/ playground/ (index.html precedence over auto-rendered README.md), we needed EITHER a duplicate copy of index.html at playground/ OR symlinks — GitHub Pages doesn't reliably follow symlinks and duplication rots.
Move index.html + app.js + style.css to playground/ (the parent). The relative refs
<link href="style.css">/<script src="app.js">already resolve correctly at both /playground/ (GitHub Pages) and /ui/ (playground server, which the server code now points at the new location).Server change: the /ui/ static routes now explicitly whitelist index.html + app.js + style.css so README.md / INSTALL.md / docs/ under playground/ don't accidentally leak at /ui/README.md etc.
The app.js API-base fallback (previous commit) already handles cross-origin fetches when loaded from benchmark.clickhouse.com or any other host.