Skip to content

Manchester | 26-ITP-May |Abdu Hassen | Sprint 3 |implement and rewrite tests#1486

Open
Abduhasen wants to merge 3 commits into
CodeYourFuture:mainfrom
Abduhasen:Sprint-3-Backlog
Open

Manchester | 26-ITP-May |Abdu Hassen | Sprint 3 |implement and rewrite tests#1486
Abduhasen wants to merge 3 commits into
CodeYourFuture:mainfrom
Abduhasen:Sprint-3-Backlog

Conversation

@Abduhasen

@Abduhasen Abduhasen commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR implements the required function and updates the related tests to match the new implementation.

Questions

N/A

@github-actions

This comment has been minimized.

Sign in to view
@Abduhasen Abduhasen added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 10, 2026
@Abduhasen Abduhasen changed the title Manchester | 26-ITP-May |Abdu Hassen | Sprint 3 |implement and rewriting tests Manchester | 26-ITP-May |Abdu Hassen | Sprint 3 |implement and rewrite tests Jul 10, 2026
cjyuan
cjyuan reviewed Jul 17, 2026
View reviewed changes
Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js Outdated
Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js Outdated
Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js Outdated
Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
cjyuan
cjyuan reviewed Jul 17, 2026
View reviewed changes
Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 17, 2026
@Abduhasen Abduhasen added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Structuring-And-Testing-Data The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Abduhasen @cjyuan