London | 26-ITP-May |Rizqah Popoola | Sprint 3 | practice tdd#1498
Open
risikatpopoola wants to merge 2 commits into
Open
London | 26-ITP-May |Rizqah Popoola | Sprint 3 | practice tdd#1498risikatpopoola wants to merge 2 commits into
risikatpopoola wants to merge 2 commits into
Conversation
risikatpopoola
added
📅 Sprint 3
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 20, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, see my comment for places to improve further
| // And a character `char` that does not exist within `str`. | ||
| // When the function is called with these inputs, | ||
| // Then it should return 0, indicating that no occurrences of `char` were found. | ||
| test("should count multiple occurrences of a character", () => { |
There was a problem hiding this comment.
Do these test descriptions match what is being tested?
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
| if(count >= 0){ | ||
| return str.repeat(count); |
There was a problem hiding this comment.
Can you re-read the task description and make sure you have done everything?
LonMcGregor
added
Reviewed
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Contributor
|
Please ignore my comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR Involves implementing functions to count, get ordinal number and repeat string as well as writing tests in jests for them.