Skip to content

Cape Town | 26-ITP-May | Liyema Mfengwana | Sprint 3 | PracticeTDD#1512

Open
LiyemaMfengwana wants to merge 7 commits into
CodeYourFuture:mainfrom
LiyemaMfengwana:practice-sprint3
Open

Cape Town | 26-ITP-May | Liyema Mfengwana | Sprint 3 | PracticeTDD#1512
LiyemaMfengwana wants to merge 7 commits into
CodeYourFuture:mainfrom
LiyemaMfengwana:practice-sprint3

Conversation

@LiyemaMfengwana

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

complete practicetdd

@LiyemaMfengwana LiyemaMfengwana added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 20, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you been running these tests on your machine? I get an error when I try to run them. Can you try to figure out what is happening?

const str = "hello";
const count = -1;

expect(() => repeatStr(str, count)).toThrow();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test ever pass?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants