fix: map entity-specific 404 codes (job/asset_not_found) to NotFound#11
Conversation
public-api returns entity-specific 404 error codes (job_not_found, asset_not_found) even though the spec documents the generic not_found, so `client.jobs.get(<missing>)` raised a bare ApiError instead of the typed NotFound the SDK promises. Map both to NotFound. (Server/spec reconciliation of the code set is a separate follow-up.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Warning
|
Testing against prod,
client.jobs.get("<missing-uuid>")raised a genericApiError("Job not found") instead of the typedNotFoundthe SDK contract promises.public-api returns entity-specific 404 error codes (
job_not_found,asset_not_found) even though the spec documents the genericnot_found, so those codes fell through_BY_CODEto the base error.Fix: map
job_not_foundandasset_not_found→NotFound. A parametrized test covers all three 404 codes. (Reconciling the spec/server code set — generic vs. entity-specific — is a separate follow-up.)🤖 Generated with Claude Code