chore(check-pr-size): remove committed binary from git and ignore it (BE-4057)#61
chore(check-pr-size): remove committed binary from git and ignore it (BE-4057)#61mattmillerai wants to merge 1 commit into
Conversation
…(BE-4057) The 3.4MB compiled check-pr-size binary was accidentally committed in #51 (a local 'go build ./...' drops it next to the sources and it got swept up by 'git add -A'). Nothing consumes it: pr-size.yml builds the tool from source into ${RUNNER_TEMP} at run time, so the tracked copy only bloats clones and silently drifts from the sources. Remove it and gitignore the build artifact path so it can't be re-committed.
mattmillerai
added
agent-coded
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
✅ No high-signal findings.
Panel: 8/8 reviewers contributed findings.
1 participant
ELI-5
A big compiled program file (3.4MB) was accidentally saved into this repo's history — like accidentally stapling a printed photocopy into a recipe book when the recipe itself is already there. Nobody uses the copy (CI always cooks fresh from the recipe), it makes every download of the repo bigger, and it slowly goes stale. This PR deletes the copy and adds a note telling git to never save it again.
What
git rm scripts/check-pr-size/check-pr-size— the 3.4MB arm64 Mach-O binary committed in harden pr-size reusable: batch check-attr, --source probe, git timeouts, comment-token scope #51 (a localgo build ./...drops the binary next to the sources; it gotgit add -A-ed).scripts/check-pr-size/check-pr-sizeto the root.gitignoreso a local build can never be re-committed.Why it's safe
Nothing consumes the tracked binary:
pr-size.ymlbuilds the tool from source at run time (go build -o "${RUNNER_TEMP}/check-pr-size" .) — never touches a tracked binary.scripts/check-pr-size/check-pr-size→ zero references outside the deleted file itself..gitignorerules never affect tracked files, and this rule is an exact single-file path — it can't mask anything else.Verification
go test ./...inscripts/check-pr-size— green (this is exactly what the path-filteredtest-pr-size.ymlCI job runs).gofmt -l+go vet ./...— clean.go build -o /tmp/... .— builds fine.git check-ignore -vconfirms the new rule matches the binary path.Judgment calls
cursor-review.ymlalso builds the tool — on currentmainit has nocheck-pr-sizereference at all (stale ticket detail; doesn't change the fix, since the load-bearing claim — nothing consumes the tracked binary — is verified above)..gitignoreor a newscripts/check-pr-size/.gitignore; chose the existing root one (already present with a Python section) over adding a new file.