Skip to content

Restore techdebt review#11965

Closed
PerfectSlayer wants to merge 1 commit into
masterfrom
bbujon/ci
Closed

Restore techdebt review#11965
PerfectSlayer wants to merge 1 commit into
masterfrom
bbujon/ci

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

This PR restores the /techdebt review to avoid pushing bloated code.

Motivation

The performance review removed the design review.

Additional Notes

Update the skill description to the new standards.

Contributor Checklist

Jira ticket: APMLP-1609

@PerfectSlayer PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Jul 15, 2026
@PerfectSlayer
PerfectSlayer requested a review from a team as a code owner July 15, 2026 16:02
@PerfectSlayer
PerfectSlayer requested a review from amarziali July 15, 2026 16:02
@PerfectSlayer PerfectSlayer added tag: ai generated Largely based on code generated by an AI or LLM type: bug fix Bug fix type: documentation labels Jul 15, 2026

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

This PR updates documentation and skill metadata only — no runtime code changes. It restores the /techdebt review guidance to the workflow by improving skill descriptions and reorganizing review guidelines in AGENTS.md. All changes are non-runtime and carry no behavioral risk.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 3f8cde5 · What is Autotest? · Any feedback? Reach out in #autotest

@dd-octo-sts

dd-octo-sts Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 13.93 s [-0.3%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent 12.93 s 12.99 s [-1.2%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 16.82 s 16.69 s [-0.1%; +1.6%] (no difference)
startup:petclinic:iast:Agent 16.86 s 16.87 s [-1.0%; +0.8%] (no difference)
startup:petclinic:profiling:Agent 16.57 s 16.72 s [-2.0%; +0.2%] (no difference)
startup:petclinic:sca:Agent 16.89 s 16.77 s [-0.2%; +1.6%] (no difference)
startup:petclinic:tracing:Agent 16.08 s 16.05 s [-0.8%; +1.2%] (no difference)

Commit: 3f8cde5e · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer
PerfectSlayer requested review from a team and removed request for amarziali July 17, 2026 08:01
@PerfectSlayer PerfectSlayer changed the title fRestore techdebt review Restore techdebt review Jul 17, 2026

@dougqh dougqh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had rather mixed results with /tech-debt on some of my performance toolkit PRs, but none-the-less, I think having this enabled by default is probably for the better.

@PerfectSlayer

Copy link
Copy Markdown
Contributor Author

I've had rather mixed results with /tech-debt on some of my performance toolkit PRs,

Did it went against the performance improvements? Or is it more about the general feedback it provided was low quality?
In general, I expect this kind of review to run poorly with performance related changes... And consider it more like safety net to product code / logic only.

@PerfectSlayer

Copy link
Copy Markdown
Contributor Author

Closing in favor of #12003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix type: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants