Scope endpoint and host view findings to the requesting user - #15441
Merged
Maffooch merged 3 commits intoJul 31, 2026
Conversation
The endpoint and host views built their finding queryset from all findings and narrowed it only by Location. A Location is shared by every product that references it, so that queryset was wider than the caller's authorized scope. Reduce it through get_authorized_findings_for_queryset, matching the check the report and API paths already apply, and add a regression test. No functional change for correctly-permissioned users.
Set the finding reporter explicitly instead of relying on the model default pointing at an existing user, and grant product access through authorized_users as well as Product_Member so the fixture is authorized under both authorization implementations.
Maffooch
approved these changes
Jul 31, 2026
blakeaowens
approved these changes
Jul 31, 2026
devGregA
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening / consistency improvement to the endpoint and host views. Reduces a finding queryset to the requesting user's authorized scope, matching the check the equivalent paths already apply, and adds a regression test.
No functional change for correctly-permissioned users: superusers and in-scope members see exactly what they saw before, in the same order.
The new test only exercises the Locations code path, so it needs a CI run with that feature enabled.