ci(dependabot): keep JavaFX on the line that still runs on Java 17 - #471
Merged
Conversation
JavaFX follows the JDK it was built against, and 21.x is the last line that runs on Java 17. The CI matrix still builds and tests on 17, so the proposed jump to 26.0.2 failed qa's compile outright: javafx-controls resolves, but Label, TextArea, FontWeight and Font are not visible to a release-17 compile and the JavaFX dev-preview tool stops building. Ignoring only major bumps, so patch and minor updates inside 21.x still arrive. The entry says when to drop it: once the matrix floor moves past 17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot proposed JavaFX
21.0.2 -> 26.0.2in #468, and it fails Build and run tests (JDK 17):JavaFX follows the JDK it was built against; 21.x is the last line that runs on Java 17.
javafx-controls:26resolves, but its classes are not visible to arelease 17compile, so the JavaFX dev-preview tool inqastops building. The CI matrix still covers JDK 17, so this bump cannot land while that floor holds.What
An ignore entry for
org.openjfx:*limited to major bumps, so patch and minor updates inside 21.x still arrive normally. The comment records the condition for removing it — the matrix floor moving past 17 — rather than leaving a rule nobody dares delete.#468 is closed by this: without the rule Dependabot re-proposes the same failing bump every Monday.
Tests
Config-only; the YAML parses. The failure being prevented is reproduced in #468's own CI run, linked above.