Skip to content

Hz/wf timestamp - #1461

Open
hazdl wants to merge 1 commit into
mainfrom
hz/wf-timestamp
Open

Hz/wf timestamp#1461
hazdl wants to merge 1 commit into
mainfrom
hz/wf-timestamp

Conversation

@hazdl

@hazdl hazdl commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This PR adds the workflow Submitted Date to the workflow accordion view. The submitted date is retrieved from the workflow status (startTime) and displayed alongside the workflow creator information.

Changes
Added submittedTime to the Workflow type.
Updated the Relay fragment to fetch startTime from workflow status.
Passed the submitted time through to WorkflowAccordion.
Displayed the submitted date in the workflow accordion using the user's local date/time format.

Testing
Verified locally that the submitted date is displayed correctly for workflows with a startTime.

Date filtering was considered but is not included in this PR. Implementing filtering across all workflows and paginated results would require backend support and is recommended as future work.

import { BaseWorkflowRelayFragment$key } from "./__generated__/BaseWorkflowRelayFragment.graphql";
import TasksFlow from "./TasksFlow";

console.error("BASE WORKFLOW RELAY IS RUNNING");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove debugging print statements

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread frontend/relay-workflows-lib/tests/views/BaseSingleWorkflowView.test.tsx Outdated
method: "POST",
headers,
credentials: "include",
// credentials: "include",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bug fix is unrelated to this pull request. Please try to use separate pull requests for separate features / bug fixes where possible.

this change is actually needed for auth gateway so this isn't a correct fix for the CORS bug that you discovered.

if useAuthGateway flag is enabled, then credentials: "include" is required.

I suggest removing this from this PR and fixing this issue in a follow-up PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncommented to be able to control when to use useAuthGateway

submittedTime?: string;
}

export interface Visit {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, if possible please squash the commit history into a single commit to keep the commit history tidy

@hazdl
hazdl force-pushed the hz/wf-timestamp branch from a6aaffa to 6941414 Compare July 21, 2026 12:07
@hazdl

hazdl commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Did the requested changes.

@hazdl
hazdl requested a review from davehadley July 21, 2026 12:25
@hazdl
hazdl force-pushed the hz/wf-timestamp branch from 6941414 to 207704d Compare July 23, 2026 14:11
@hazdl
hazdl force-pushed the hz/wf-timestamp branch from 207704d to bc0c1fb Compare July 23, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants