fix!: align embedding input order with PyTorch#808
Merged
Conversation
voltjia
force-pushed
the
fix/align-embedding-python-api
branch
from
July 24, 2026 06:40
e2589f8 to
089b33a
Compare
voltjia
force-pushed
the
fix/align-embedding-python-api
branch
from
July 24, 2026 08:02
089b33a to
59566ad
Compare
voltjia
force-pushed
the
fix/align-embedding-python-api
branch
from
July 24, 2026 08:27
59566ad to
755077d
Compare
voltjia
marked this pull request as ready for review
July 24, 2026 08:36
embedding input order with PyTorch
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Embeddinginput order toinput, weight, matchingtorch.nn.functional.embedding.Motivation
PR #799 accidentally changed the leading tensors from the public PyTorch order to the lower-level ATen order
weight, indices. These are the most important positional arguments, and accepting them in reverse order makes the user-facing API misleading and incompatible withtorch.nn.functional.embedding.This is a follow-up to #799; no standalone issue is associated with the correction.
Type of Change
feat- new feature / new operator / new platformfix- bug fixperf- performance improvement (no behavioral change)refactor- code restructuring without behavior changetest- adding or fixing tests onlydocs- documentation onlybuild/ci- build system or CI configurationchore- tooling, formatting, or other non-code changesPlatforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Test Results on Supported Platforms
tests/test_embedding.py: 42 passedFull pytest output
Benchmark / Performance Impact
N/A. This changes argument order and names only; the kernel implementation is unchanged.
Notes for Reviewers
API alignment
embedding(input, weight, padding_idx, scale_grad_by_freq, sparse, out)outremains last perCONTRIBUTING.md.F.embedding(input, weight, padding_idx=None, max_norm=None, norm_type=2.0, scale_grad_by_freq=False, sparse=False)embedding(input, weight, out).max_normandnorm_typeremain out of scope because PyTorch handles renormalization in its Python functional wrapper before calling the low-level embedding operation.clang-format21.1.8 passed with--dry-run --Werror; Ruff passed fortests/test_embedding.py.