Fix macOS rpath: emit one -rpath per path instead of colon-joining#222
Merged
Conversation
Emit one -rpath per path. Colon-joining works only for ELF (Linux); on Mach-O the colon is literal, producing a single unusable LC_RPATH.
antonwolfy
requested review from
jharlow-intel,
ndgrigorian and
xaleryb
as code owners
July 23, 2026 13:13
jharlow-intel
approved these changes
Jul 23, 2026
jharlow-intel
left a comment
jharlow-intel
left a comment
Collaborator
There was a problem hiding this comment.
Good ole macos, thanks for fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Meson migration gh-174 built the extensions' runtime search path by colon-joining two paths into a single
-Wl,-rpath,argument:Colon-as-separator is an ELF/Linux convention. On macOS (Mach-O) each
-rpathproduces exactly oneLC_RPATHload command and the string is taken verbatim — the colon is not a separator. As a result, macOS extensions shipped a single unusable rpath entry:so
@rpath/libmkl_rt.*.dylibcould not be resolved from the baked-in rpath alone.This PR emits one
-Wl,-rpath,argument per path, restoring the exact per-entry behavior of the legacysetup.py(runtime_library_dirs=["$ORIGIN/../..", "$ORIGIN/../../.."]). This is correct on both Mach-O and ELF.