-
Notifications
You must be signed in to change notification settings - Fork 25
Move build system to meson-python
#303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ndgrigorian
wants to merge
39
commits into
master
Choose a base branch
from
use-meson-build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
6f89ebf
move build system to meson
ndgrigorian 4f4e9aa
use meson-python in meta.yaml files
ndgrigorian cc718bf
add cmake to build system dependencies
ndgrigorian d6874f5
don't set MKLROOT
ndgrigorian 1e84694
update clang and pip builds
ndgrigorian b1633ee
remove MKLROOT from build_pip
ndgrigorian 9687eaf
add standard clang build workflow
ndgrigorian 8ae541d
make ninja explicit in pyproject.toml and meta.yamls
ndgrigorian 46b79fc
use pip install in conda-forge build scripts
ndgrigorian a6c4743
remove jq from pip build
ndgrigorian 4e1bba0
build_pip.yaml -> build_pip.yml
ndgrigorian e507cde
add comment justifying get_compiler call in meson build
ndgrigorian 29980c5
remove redundant mkl pip installation in standard clang build
ndgrigorian 54f7a39
install mkl-service with --no-deps in clang build
ndgrigorian 0c79c9a
add openmp as explicit conda package requirement
ndgrigorian 6dab296
add mkl_threading option
ndgrigorian 25f188e
use gnu_thread on Linux conda-forge builds
ndgrigorian 3c9b222
Merge branch 'master' into use-meson-build
ndgrigorian de2e7b0
Merge remote-tracking branch 'origin/master' into use-meson-build
vlad-perevezentsev 2c29dd5
Add missing python source file to meson.build
vlad-perevezentsev 920ac14
Merge remote-tracking branch 'origin/master' into use-meson-build
vlad-perevezentsev 20b0b43
improve meson.build portability
vlad-perevezentsev 8b493ef
Set RPATH via link_args
vlad-perevezentsev 9eb6790
Remove redundant meson dependency
vlad-perevezentsev 72d0304
Exclude AGENTS.md from tests installation
vlad-perevezentsev 7f22b97
Correct numpy version specifier
vlad-perevezentsev 955490a
Update copilot-instructions
vlad-perevezentsev 9cbd93b
Uppdate AGENTS.md files
vlad-perevezentsev 67991c8
Update README
vlad-perevezentsev 291c9fb
Add error propagation and build dir cleanup
vlad-perevezentsev 7558842
Fix typos
vlad-perevezentsev f2fba7a
Remove redundant meson dependency in conda-recipe-cf
vlad-perevezentsev 54edcb2
test: align conda-recipe build scripts with mkl-service using python …
vlad-perevezentsev b9964a7
Remove unused env variables from build_pip.yml
vlad-perevezentsev 16755bc
Add wheels upload to conda-package workflow
vlad-perevezentsev 14d7181
Add numpy to ignore_run_exports
vlad-perevezentsev f6d7e2a
Remove redundant LDFLAGS from build.sh
vlad-perevezentsev be607c4
Remove macOS RPATH support
vlad-perevezentsev d11fbe4
Check llvm-openmp linkage
vlad-perevezentsev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| name: Build project with standard clang compiler | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [master] | ||
|
|
||
| permissions: read-all | ||
|
|
||
| jobs: | ||
| build-with-standard-clang: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| python: ["3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| numpy_version: ["'numpy>=2'"] | ||
|
|
||
| env: | ||
| COMPILER_ROOT: /usr/bin | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash -el {0} | ||
|
|
||
| steps: | ||
| - name: Cancel Previous Runs | ||
| uses: styfle/cancel-workflow-action@3155a141048f8f89c06b4cdae32e7853e97536bc # 0.13.0 | ||
| with: | ||
| access_token: ${{ github.token }} | ||
|
|
||
| - name: Install Dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y clang | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0 | ||
| with: | ||
| python-version: ${{ matrix.python }} | ||
| architecture: x64 | ||
|
|
||
| - name: Checkout repo | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Install mkl_fft dependencies | ||
| run: | | ||
| pip install meson-python ninja cmake cython mkl-devel | ||
| pip install ${{ matrix.numpy_version }} | ||
|
|
||
| - name: Build mkl_fft | ||
| run: | | ||
| export CC=${{ env.COMPILER_ROOT }}/clang | ||
| pip install . --no-build-isolation --no-deps --verbose | ||
|
|
||
| - name: Run mkl_fft tests | ||
| run: | | ||
| pip install pytest mkl-service scipy | ||
| # mkl_fft cannot be installed in editable mode, we need | ||
| # to change directory before importing it and running tests | ||
| cd .. | ||
| python -m pytest -sv --pyargs mkl_fft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| ## Vendored files | ||
|
|
||
| File `conv_template.py` is copied from NumPy's numpy/distutils folder, since | ||
| `numpy.distutils` is absent from the installation layout starting with | ||
| Python 3.12 | ||
| Files `conv_template.py` and `process_src_template.py` are copied from NumPy's numpy/numpy/_build_utils folder |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.