Fix cross-language inconsistencies in gmd()#8
Open
Yicheng-Zhao1999 wants to merge 1 commit into
Open
Conversation
- Variable names matched case-insensitively and normalized to the dataset's canonical casing, e.g. "rgdp" -> "rGDP" (KMueller-Lab#2) - list/current/load keywords accepted case-insensitively (KMueller-Lab#3) - Trim whitespace-padded version, e.g. " 2026_03 " (KMueller-Lab#4) - sources + a variable the source lacks now raises an error instead of printing a message and returning None (KMueller-Lab#6) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-language consistency fixes (Python)
Aligns
global_macro_data/gmd.pywith the R/Stata packages while reading the sameS3 dataset. Verified against live version
2026_03.Coverage (this package = Python)
rawwith a non-boolean valueWhat changed
variables="rgdp"matches and is normalized to canonical casing (rGDP);invalid names still error.
version="LIST",sources="LOAD",cite="LOAD",vars="LIST"now work.version=" 2026_03 "is trimmed (country/variable tokens already were).GMDCommandErrorinstead of printinga message and returning
None.Not changed
Pending decision
rawwith a non-boolean value. Python uses plain truthiness, so any non-emptystring enables raw — including
raw="0"/raw="false"(a footgun). Target needs adecision: strict (only real booleans) vs lenient coercion ("true"/"1"/"yes" on,
"false"/"0"/"no" off).