Mobile Audit W1-B: Accessibility Foundation#4697
Open
iscekic wants to merge 14 commits into
Open
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe only change since the previous review (adding Files Reviewed (1 file)
Previous Review Summary (commit f7b5e02)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit f7b5e02)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryThe highest-risk finding is a font-scale/line-height mismatch in the new bounded PR-diff metrics helper ( Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (60 files)
Reviewed by claude-sonnet-5 · Input: 18 · Output: 3.6K · Cached: 391.1K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile Audit W1-B — Accessibility Foundation
Implements the 13-slice accessibility-foundation plan for the mobile app (iOS + Android). All changes are scoped to
apps/mobile/; no web/service/DB/native-sibling code is touched. Each slice landed as its own small commit with co-located unit tests.Two audit-reproduced defects are the acceptance anchors:
Verify/Resend/Backwere occluded by the number pad at Dynamic Type XXXL.Slices
allowFontScaling={false}, variable-height rows)muted-softtext + contrast-pair assertion (kept in sync acrossglobal.cssand the static color mirror)hitSlopgosubmits the emailKeyboardAvoidingView)Design principle
UX primacy governs: font scaling is bounded to preserve density, 44pt targets are reached via
hitSloprather than bulk, and screen-reader affordances (announce/focus,accessibilityActions, labels/roles) are preferred over visible changes.Verification
pnpm typecheck && pnpm lint && pnpm check:unused && pnpm testgreen (214 test files / 1725 tests).Non-goals (preserved audit refutations)
Normal Agent keyboard avoidance, malformed deep-link handling, force-update foreground-recheck (QB-18), generic Reduce-Motion, persisted-cache durability, and landscape/iPad orientation are explicitly out of scope.