Remove Legacy Forms from Settings Dropdowns

[n7studios]

Summary

Removes legacy Kit forms from every settings dropdown across the plugin, while preserving any legacy form ID already saved to a post, page, category, block, integration mapping or plugin setting.

Legacy forms are a deprecated Kit resource. New assignments should always be to v4 forms, but existing customers who already have legacy forms selected should continue to work at this time - both at render time and in the admin UI, where the saved legacy form should still show as the currently-selected dropdown option rather than silently reverting to "None".

Testing

Tests added:

Integration (tests/Integration/ResourceFormsTest.php):

• testGetNonLegacy — get_non_legacy() returns v4 forms and excludes legacy; every returned form has a format key
• testNonLegacyExist — helper returns true when at least one v4 form exists
• testGetSelectFieldAllExcludesLegacyForms — rendered HTML has no <option> for the legacy form when a v4 form is the selected value
• testGetSelectFieldAllPreservesSelectedLegacyForm — when a legacy form ID is the selected value, the option is appended and marked selected

End-to-end:

• SelectOptionOrderCest::testLegacyFormsExcludedFromDropdowns — no legacy <option> in Post metabox, Page metabox, Category term Add, Settings > Kit > General
• SelectOptionOrderCest::testPreservesSelectedLegacyFormInDefaultFormsSetting — Settings > Kit > General with a legacy form pre-assigned still shows it as selected
• SelectOptionOrderCest::testPreservesSelectedLegacyFormOnCategoryTerm — Category term with a legacy form in term meta still shows it as selected
• SelectOptionOrderCest::testPreservesSelectedLegacyFormOnPostMetabox — Post with a legacy form in post meta still shows it as selected in the classic-editor metabox
• PageBlockFormCest::testFormBlockSidebarDropdownExcludesLegacyForms — Kit Form block sidebar Form dropdown has no legacy option
• PageBlockFormCest::testFormBlockPreservesSelectedLegacyForm — Kit Form block preseeded with a legacy form attribute still shows it as selected in the sidebar AND renders on the frontend
• PageBlockFormBuilderCest::testFormBuilderBlockSidebarFormDropdownExcludesLegacyForms — Form Builder block sidebar form_id dropdown has no legacy option
• PageBlockFormBuilderCest::testFormBuilderBlockPreservesSelectedLegacyForm — Form Builder block preseeded with a legacy form_id attribute still shows it as selected in the sidebar
• BlockEditorFormCest::testPluginSidebarFormDropdownExcludesLegacyForms — Gutenberg plugin sidebar Form dropdown has no legacy option across page, post, article
• BlockEditorFormCest::testPluginSidebarPreservesSelectedLegacyForm — Page with a legacy form in post meta still shows it as selected in the Gutenberg plugin sidebar

Tests removed (all previously selected a legacy form via a dropdown, which the dropdown no longer offers):

• PageBlockFormCest::testFormBlockWithValidLegacyFormParameter
• PageBlockFormBuilderCest::testFormBuilderBlockWithLegacyFormEnabled
• ClassicEditorFormCest::testAddNewPostTypeUsingDefinedLegacyForm
• BlockEditorFormCest::testAddNewPostTypeUsingDefinedLegacyForm
• WidgetFormCest::testLegacyFormWidgetWithValidLegacyFormParameter
• WidgetFormCest::testBlockFormBlockWithValidLegacyFormParameter
• EditFormLinkCest::testEditFormLinkOnPageWithLegacyForm
• ContactForm7FormCest::testSettingsContactForm7ToKitLegacyFormMapping
• ForminatorCest::testSettingsForminatorFormToKitLegacyFormMapping
• WishListMemberCest::testWLMToKitLegacyFormMappingOnLevelAdded
• WishListMemberCest::testWLMToKitLegacyFormMappingOnLevelRemoved
• ElementorFormCest::testFormWidgetWithValidLegacyFormParameter
• DiviPluginFormCest::testFormModuleWithValidLegacyFormParameter
• DiviThemeFormCest::testFormModuleWithValidLegacyFormParameter

Checklist

• I have written a test and included it in this PR
• I have run all tests and they pass
• The code passes when running the PHP CodeSniffer
• Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
• Security and Sanitization requirements have been followed
• I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

[github-actions]

WordPress Playground

🚀 Your PR has been built and is ready for testing in WordPress Playground!

Click here to test your changes in WordPress Playground