Skip to content

Remove Legacy Landing Pages from Settings Dropdowns - #1153

Draft
n7studios wants to merge 1 commit into
remove-legacy-forms-dropdownfrom
remove-legacy-landing-pages-dropdown
Draft

Remove Legacy Landing Pages from Settings Dropdowns#1153
n7studios wants to merge 1 commit into
remove-legacy-forms-dropdownfrom
remove-legacy-landing-pages-dropdown

Conversation

@n7studios

Copy link
Copy Markdown
Contributor

Summary

Removes legacy Kit landing pages from every settings dropdown across the plugin, while preserving any legacy landing page (by ID or by pre-1.9.6 URL string) already saved to a page's post meta.

Testing

Tests added:

Integration (tests/Integration/ResourceLandingPagesTest.php):

  • testGetNonLegacyget_non_legacy() returns v4 landing pages and excludes legacy; every returned page has embed_url and no url key
  • testNonLegacyExist — helper returns true when v4 pages exist
  • testIsLegacyWithLegacyID — true for legacy ID
  • testIsLegacyWithURLString — true when passed a URL string (pre-1.9.6 storage)
  • testIsLegacyWithV4ID — false for v4 ID
  • testIsLegacyWithInvalidID — false for an ID that doesn't resolve

End-to-end:

  • ClassicEditorLandingPageCest::testLegacyLandingPagesExcludedFromMetaboxDropdown — Classic editor metabox Landing Page dropdown has no legacy option
  • ClassicEditorLandingPageCest::testMetaboxPreservesSelectedLegacyLandingPageByID — page preseeded with legacy ID in post meta shows as selected in metabox AND still renders on the frontend, including the WordPress site icon replacing the Kit favicon
  • ClassicEditorLandingPageCest::testMetaboxPreservesSelectedLegacyLandingPageByURL — page preseeded with a legacy URL string (pre-1.9.6 storage) shows as selected in metabox
  • BlockEditorLandingPageCest::testLegacyLandingPagesExcludedFromPluginSidebar — Gutenberg plugin sidebar Landing Page dropdown has no legacy option
  • BlockEditorLandingPageCest::testPluginSidebarPreservesSelectedLegacyLandingPage — page preseeded with legacy ID shows as selected in Gutenberg plugin sidebar
  • PageLandingPageSetupWizardCest::testLegacyLandingPagesExcludedFromSetupWizard — Setup Wizard landing page picker has no legacy option

Tests removed (all previously selected a legacy landing page from a dropdown that no longer offers it):

  • ClassicEditorLandingPageCest::testAddNewPageUsingDefinedLegacyLandingPage
  • ClassicEditorLandingPageCest::testLegacyLandingPageSiteIcon (site-icon coverage moved into testMetaboxPreservesSelectedLegacyLandingPageByID)
  • BlockEditorLandingPageCest::testAddNewPageUsingDefinedLegacyLandingPage
  • BlockEditorLandingPageCest::testLegacyLandingPageSiteIcon
  • PageLandingPageSetupWizardCest::testAddNewLegacyLandingPage

Checklist

@n7studios n7studios added this to the 3.3.7 milestone Jul 29, 2026
@n7studios n7studios self-assigned this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant