Skip to content

feat(session): add SUNSHINE_CLIENT_NAME environment variable - #5465

Open
oryschakj wants to merge 4 commits into
LizardByte:masterfrom
oryschakj:feat/client-name-env
Open

feat(session): add SUNSHINE_CLIENT_NAME environment variable#5465
oryschakj wants to merge 4 commits into
LizardByte:masterfrom
oryschakj:feat/client-name-env

Conversation

@oryschakj

@oryschakj oryschakj commented Jul 30, 2026

Copy link
Copy Markdown

Description

This PR populates a new environment variable, "SUNSHINE_CLIENT_NAME", with the friendly name given for the client cert during the PIN pairing process.

The use case for this is being able to reference specific clients in host scripts. For example, if "Justin-TV" should get a different HDR calibration setting in KDE Plasma than "Justin-Macbook" I can match on the client name to set it instead of the requested height/width (which works until you have more than one device requesting the same resolution).

I've tested this on my own devices:

SUNSHINE_CLIENT_NAME=Justin-MacbookPro
SUNSHINE_CLIENT_AUDIO_CONFIGURATION=2.0
SUNSHINE_CLIENT_GCMAP=0
SUNSHINE_CLIENT_WIDTH=3456
SUNSHINE_APP_ID=881448767
SUNSHINE_CLIENT_AUDIO_SURROUND_PARAMS=
SUNSHINE_CLIENT_ENABLE_SOPS=true
SUNSHINE_CLIENT_FPS=120
SUNSHINE_APP_NAME=Desktop
SUNSHINE_CLIENT_HDR=true
SUNSHINE_CLIENT_HOST_AUDIO=false
SUNSHINE_CLIENT_HEIGHT=2160

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

Unit tests were run and reviewed for potential updates but I couldn't think of a reasonable way to cover this change.

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Web-based AI helped with brainstorming where to implement the change and then I promptly ignored its recommendations and came up with a solution I liked better. No AI ever touched the coding environment.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant