refactor: smart pointers and fix ownership - #167
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 59.81% 61.50% +1.68%
==========================================
Files 5 5
Lines 443 439 -4
Branches 162 159 -3
==========================================
+ Hits 265 270 +5
+ Misses 121 110 -11
- Partials 57 59 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #167 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Matrix: Linux-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Matrix: Windows-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Matrix: macOS-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
ReenigneArcher
force-pushed
the
refactor/sonar-fixes
branch
from
July 28, 2026 01:49
074efc9 to
7489e05
Compare
Replace raw pointer members (app, trayIcon, trayTopMenu) with std::unique_ptr in QtTrayMenu. Consolidate tray_qt module-level globals into a State struct accessed via a function-local static. Move tray test fixtures from global arrays into per-fixture instance members to eliminate shared mutable state between tests. Replace std::system shell invocations with posix_spawnp for notification cleanup. Use placement new instead of reinterpret_cast+memcpy for C struct initialization over raw buffers.
ReenigneArcher
force-pushed
the
refactor/sonar-fixes
branch
from
July 28, 2026 02:37
7489e05 to
1773925
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace raw pointer members (app, trayIcon, trayTopMenu) with std::unique_ptr in QtTrayMenu. Consolidate tray_qt module-level globals into a State struct accessed via a function-local static. Move tray test fixtures from global arrays into per-fixture instance members to eliminate shared mutable state between tests. Replace std::system shell invocations with posix_spawnp for notification cleanup. Use placement new instead of reinterpret_cast+memcpy for C struct initialization over raw buffers.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.