test: add mouse positioning helpers for tray icon - #169
Merged
Conversation
Add tray_position_mouse_over_icon() and tray_restore_mouse_position() C API functions, backed by QtTrayMenu methods, to move and restore the cursor during testing. Use these in tests on GitHub Actions where mouse position matters for tray menu screenshots.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 61.50% 61.74% +0.24%
==========================================
Files 5 5
Lines 439 515 +76
Branches 159 194 +35
==========================================
+ Hits 270 318 +48
- Misses 110 135 +25
- Partials 59 62 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #169 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Matrix: Linux-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Matrix: Windows-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Matrix: macOS-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Improve mouse positioning for tray interactions when tray icon geometry is unavailable by deriving a fallback target from screen/panel edges, with platform-specific defaults. Also make cursor position/restore validation tolerant to small movement offsets instead of exact pixel matches. Unit tests were updated to avoid hard-failing on CI cursor positioning and only require restore success when positioning succeeded.
ReenigneArcher
force-pushed
the
test/position-mouse
branch
from
July 28, 2026 19:18
678a0b4 to
099d6ab
Compare
Updates CI on macOS to fully configure screen recording by writing replayd approval data, restarting replayd, and clarifying step messaging. In QtTrayMenu, adds a bounded cursor-position wait loop with polling and timeout so mouse move/restore checks are more reliable instead of relying on a single immediate position read.
ReenigneArcher
force-pushed
the
test/position-mouse
branch
from
July 28, 2026 19:43
099d6ab to
00c7b43
Compare
Extend the GitHub Actions notification readiness workaround to also apply on macOS, not just Windows.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add tray_position_mouse_over_icon() and tray_restore_mouse_position() C API functions, backed by QtTrayMenu methods, to move and restore the cursor during testing. Use these in tests on GitHub Actions where mouse position matters for tray menu screenshots.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.