MDEV-40452: ASAN builds complain about enormous stack usage - #5463
Merged
Conversation
…n b/c of the reference pointer used for stack usage calculations.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump DuckDB engine to gamma maturity and fix ASAN stack usage
What
Promotes the DuckDB storage engine to
gammaplugin maturity, addsan ASAN/UBSAN build option to
build.sh, and fixes MDEV-40452 whereASAN builds reported enormous stack consumption due to using a stack
reference pointer for stack-usage calculations.
Key changes
-aflag enabling-DWITH_ASAN/ASAN_SCOPE/UBSAN; disable leak detection during bootstrap.fiber_scan.ccnow setsthd->thread_stackvia newfiber_context_stack_top()helper infiber_context.h, and forces ucontext backend under ASAN.ha_duckdb.ccandduckdb.cnfmoved fromalphatogamma.register_mysql_compat_functions→register_mariadb_compat_functionsacrossduckdb_manager.cc/duckdb_mysql_compat.{cc,h}.temporary-table-support-design.mdplus minor doc touch-ups.How to test
Build with ASAN:
./storage/duckdb/build.sh -a, then run the DuckDBmysql-test suite and confirm no stack-usage or leak warnings.