Skip to content

chore: improve unsub failure and retry logic #9678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahar-fehri wants to merge 9 commits into
base: main
Choose a base branch
from
Open

chore: improve unsub failure and retry logic #9678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f270feb
chore: improve unsub failure and retry logic
sahar-fehri Jul 28, 2026
fb84a1e
chore: lint and changelog
sahar-fehri Jul 28, 2026
f2b5f30
chore: ut
sahar-fehri Jul 28, 2026
ae60f4e
chore: lint
sahar-fehri Jul 28, 2026
2107b2f
chore: fix flush unused sub on return to same token
sahar-fehri Jul 28, 2026
74a7e01
feat: se Cockatiel for OHLCV unsubscribe retries
sahar-fehri Jul 29, 2026
43628d8
Merge branch 'main' into chore/enhance-unsub-failure-cleanup-logic-ohlcv
sahar-fehri Jul 29, 2026
a2e47cf
feat: derive OHLCV unsub maxAttempts from backoff delays
sahar-fehri Jul 29, 2026
54e16dd
feat: lint
sahar-fehri Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/core-backend/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
### Changed

- **BREAKING:** Align `V6_DEFI_POSITION_TYPES` (and inferred `V6DeFiPositionType`) with Accounts API / Zerion wallet fungible position types: `deposit`, `loan`, `locked`, `staked`, `reward`, `wallet`, `investment` ([#9683](https://github.com/MetaMask/core/pull/9683))

### Fixed

- `OHLCVService` now flushes grace-period channels when subscribing to a different asset/interval, retries failed WebSocket unsubscribes with backoff before forcing reconnection, and only removes channel tracking after a successful unsubscribe ([#9678](https://github.com/MetaMask/core/pull/9678))

## [7.0.0]

### Added
Expand Down
1 change: 1 addition & 0 deletions packages/core-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
"@metamask/utils": "^11.11.0",
"@tanstack/query-core": "^5.62.16",
"async-mutex": "^0.5.0",
"cockatiel": "^3.1.2",
"uuid": "^8.3.2"
},
"devDependencies": {
Expand Down
Loading