feat(account-tree-controller): add get/set account group methods - #9739
Open
hmalik88 wants to merge 17 commits into
Open
feat(account-tree-controller): add get/set account group methods#9739hmalik88 wants to merge 17 commits into
hmalik88 wants to merge 17 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 36886ae. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Added
getAccountFromSelectedAccountGroupandsetSelectedAccountGroupByAccountIdmethodsReferences
N/A
Checklist
Note
Medium Risk
Changes how the selected account is synced to AccountsController and introduces APIs that drive account/group selection; behavior is well-tested but affects core wallet selection paths.
Overview
Adds
getAccountFromSelectedAccountGroupandsetSelectedAccountGroupByAccountIdonAccountTreeController, exposed via messenger actions and package exports, with changelog and broad unit tests.getAccountFromSelectedAccountGroupis intended as the group-based replacement forAccountsController:getSelectedAccount/getSelectedMultichainAccount. Without a chain ID it applies the existing EVM-priority pick (first EVM in the group, else first account). With an optional CAIP-2chainIdit returns the first account in the selected group whose scopes match, validates the chain ID, and returnsundefinedwhen nothing matches.setSelectedAccountGroupByAccountIdresolves the account’s group from the internal tree map and delegates tosetSelectedAccountGroup, throwing if the account is not in the tree.Internal selection logic is refactored:
#getDefaultAccountFromAccountGroupIdbecomes#getAccountFromAccountGroupId, returning a fullInternalAccountinstead of an ID.#setSelectedAccountGroupnow forwardsaccountToSelect.idtoAccountsController:setSelectedAccount(previously passed the account object).Reviewed by Cursor Bugbot for commit 399b753. Bugbot is set up for automated code reviews on this repo. Configure here.