feat(profile-sync-controller): add SRP tagging - #9741
Open
mathieuartu wants to merge 4 commits into
Open
Conversation
mathieuartu
temporarily deployed
to
default-branch
July 31, 2026 14:33 — with
GitHub Actions
Inactive
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 940cd11. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
References
Related to: https://consensyssoftware.atlassian.net/browse/MUL-2063
Checklist
Note
Medium Risk
Changes the SRP login signed message format and auth request payload; misalignment with the auth server or wrong identifier_type mapping could affect sign-in or analytics, though seedless lookup failures degrade to SRP.
Overview
Extends SRP profile login so
/srp/logincarries richer metadata: the signedraw_messagebecomesmetamask:<nonce>:<pubkey>:primary|secondary(first HD entropy source vs any other), and the request body includesmetametrics.identifier_type(SRP,GOOGLE,APPLE, orTELEGRAM).AuthenticationControllerresolves the tag from the entropy source and maps the primary source’s social vault viaSeedlessOnboardingController:getState(authConnection); secondary SRPs staySRP, and missing/unavailable seedless state soft-fails toSRP. The SRP JWT bearer flow andauthenticate()service accept optionalgetLoginTag/getLoginIdentifierTypehooks (defaults:primaryandSRP). Multi-SRP sign-in now signs two distinct messages instead of one.Adds
@metamask/seedless-onboarding-controlleras a dependency and documents the change in the package changelog.Reviewed by Cursor Bugbot for commit d2f6610. Bugbot is set up for automated code reviews on this repo. Configure here.