fix(core): resolve git metadata in worktrees#2475
Draft
matthewgrossman wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent no-change builds in linked Git worktrees from repeatedly rebuilding
openshell-coreand its downstream crates. The core build script currently watches paths under../../.git, but.gitis a file in a linked worktree, so Cargo sees the requested metadata paths as missing and reruns the build script on every invocation.This PR resolves the real Git metadata paths before emitting Cargo change directives. It fixes repeated builds within an existing linked worktree; improving cache reuse for the first build in a different worktree remains a separate follow-up.
Related Issue
None.
Changes
HEADandrefs/tagsthroughgit rev-parse --git-pathinstead of assuming.gitis a directory.cargo:rerun-if-changedonly for Git metadata paths that actually exist.Testing
mise run pre-commitpassescargo test -p openshell-corepasses (338 unit tests and 3 new integration tests)cargo clippy -p openshell-core --all-targets -- -D warningspassesmainand rebuilt 19 workspace crates; this branch took 8.35 seconds and compiled noneChecklist