Skip to content

[Common] Enable arch support for Rubin - #3275

Open
denera wants to merge 1 commit into
NVIDIA:mainfrom
denera:common/rubin-build-flow
Open

[Common] Enable arch support for Rubin#3275
denera wants to merge 1 commit into
NVIDIA:mainfrom
denera:common/rubin-build-flow

Conversation

@denera

@denera denera commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Gate arch-specific Rubin codegen on CUDA 13.4+.
  • Drop redundant cute includes from the cast-fusion kernels that caused compile errors on cute::maybe_ifence() and cute::maybe_warp_switch().
  • Enable stochastic rounding for ArchSpecific<107>.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@denera denera changed the title [Common] Adding Rubin-specific SM107a compile target under the SM100 arch family [Common] Update Build Flow for Rubin-readiness Jul 29, 2026
@denera
denera requested a review from ptrendx July 29, 2026 17:29
Comment thread transformer_engine/common/CMakeLists.txt Outdated
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR prepares the common CUDA library for Rubin.

  • Adds SM107a architecture-specific compilation for CUDA 13.4 and newer.
  • Enables stochastic rounding for architecture 107.
  • Removes unused CUTLASS includes from Hadamard-transform fusion sources.

Confidence Score: 5/5

The PR appears safe to merge.

The corrected CUDA toolkit guard now reaches the SM107a target for default CUDA 13.4 builds, and no blocking failure remains.

Important Files Changed

Filename Overview
transformer_engine/common/CMakeLists.txt Adds a valid CUDA 13.4 version guard that appends 107a when architecture 100 family compilation is enabled; the previously reported malformed guard is fixed.
transformer_engine/common/util/ptx.cuh Extends the existing architecture-specific stochastic-rounding capability check to architecture 107.
transformer_engine/common/hadamard_transform/graph_safe_group_row_cast_col_hadamard_transform_cast_fusion.cu Removes two unused CUTE includes without changing kernel behavior.
transformer_engine/common/hadamard_transform/group_hadamard_transform_cast_fusion.cu Removes two unused CUTE includes without changing kernel behavior.
transformer_engine/common/hadamard_transform/group_row_cast_col_hadamard_transform_cast_fusion.cu Removes two unused CUTE includes without changing kernel behavior.
transformer_engine/common/hadamard_transform/hadamard_transform_cast_fusion.cu Removes two unused CUTE includes without changing kernel behavior.
transformer_engine/common/hadamard_transform/row_cast_col_hadamard_transform_cast_fusion.cu Removes two unused CUTE includes without changing kernel behavior.

Reviews (3): Last reviewed commit: "[Common] Enable arch support for Rubin" | Re-trigger Greptile

@denera
denera force-pushed the common/rubin-build-flow branch from 687293b to 05d021b Compare July 29, 2026 18:13
1. Gate arch-specific Rubin codegen on CUDA 13.4+.

2. Drop redundant cute includes from the cast-fusion kernels that caused
   compile errors on `cute::maybe_ifence()` and `cute::maybe_warp_switch()`.

3. Enable stochastic rounding for `ArchSpecific<107>`.

Signed-off-by: Alp Dener <adener@nvidia.com>
@denera
denera force-pushed the common/rubin-build-flow branch from 05d021b to 88e429f Compare July 30, 2026 19:27
@denera denera self-assigned this Jul 30, 2026
@denera denera changed the title [Common] Update Build Flow for Rubin-readiness [Common] Enable arch support for Rubin Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant