Add opt-in reduced precision output for cuDNN MXFP8 norm - #3288
Open
sraman-rgb wants to merge 1 commit into
Open
Add opt-in reduced precision output for cuDNN MXFP8 norm#3288sraman-rgb wants to merge 1 commit into
sraman-rgb wants to merge 1 commit into
Conversation
Comment on lines
+307
to
310
| const bool use_input_dtype = cudnnGetVersion() >= 92500 && _fp8_out && _ndim_scale_block == 1 && | ||
| use_cudnn_mxfp8_norm_output_in_input_dtype(); | ||
| const auto ZDtype = use_input_dtype ? itype : (_fp8_out ? ctype : otype); | ||
| _z->set_output(!_fp8_out).set_data_type(get_cudnn_fe_dtype(ZDtype)); |
Contributor
There was a problem hiding this comment.
The existing MXFP8 normalization tests leave NVTE_CUDNN_MXFP8_NORM_OUTPUT_IN_INPUT_DTYPE disabled, so CI does not exercise graph construction or output correctness when this branch changes the virtual normalization output from FP32 to FP16 or BF16.
Knowledge Base Used: Common core (transformer_engine/common)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Contributor
Greptile SummaryAdds an opt-in cuDNN MXFP8 normalization output mode.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Add opt-in reduced precision output for ..." | Re-trigger Greptile |
Signed-off-by: sraman-rgb <sraman@nvidia.com>
sraman-rgb
force-pushed
the
fix/cudnn-mxfp8-norm-output-dtype
branch
from
July 30, 2026 18:03
087adbe to
c860887
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: