Remove worldwide polygon wedges and bands - #29
Conversation
There was a problem hiding this comment.
Occumed79 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe PR updates MVT polygon merging and overscaling, adds worldwide overview URL overrides and land-layer handling, and introduces CI workflows that rebuild PMTiles assets and run Playwright polygon regression captures. ChangesWorldwide polygon validation
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Occumed79 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Occumed79 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Problem
Production globe screenshots show giant blue wedges, circular bands, and tile-spanning translucent polygons across North America, the Pacific, Australia, and Asia.
The root cause is the server-side MVT merger treating numeric polygon IDs as globally unique across 754 independently generated archives. Separate extracts reuse IDs for unrelated
land,landcover, anddepthpolygons, so clipped rings were appended into one feature and encoded as giant shapes. The gateway also merged a second basemaplandlayer on top of the authoritative physical surface.Repair
landmask, with duplicate basemap land excluded;Release requirement
The existing published
occumed-world-overview.pmtilescontains geometry generated by the old merger. After the rebuilt-overview artifact is visually approved, the corrected overview asset must be uploaded with--clobberbefore production can be considered repaired.Merge rule
Keep this PR draft and unmerged until the rebuilt candidate screenshots show no wedges, bands, giant circles, blank areas, or source switching.
Summary by CodeRabbit
Bug Fixes
Tests