Swampfire nano mission bug workaround | refactoring Missions.cpp#322
Open
filkata123 wants to merge 1 commit into
Open
Swampfire nano mission bug workaround | refactoring Missions.cpp#322filkata123 wants to merge 1 commit into
filkata123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current logic in Missions.cpp only checks whether all necessary quest items for a task have been gathered once an item is dropped. If the logic somehow fails (which seems to happen to many people during the swampfire nano mission as per the FAQ; maybe the packet fails to deliver?), then the player will be stuck since the quest items will be full and the logic which ends the task will not be accessible by the code anymore. Then, they won't be able to progress in the game until a dev helps them.
This fix takes out the logic which checks if all the items have been gathered outside of the code section that is only accessible once an item is dropped. Then, if the issue is encountered, the player can just kill one or more npcs of the type they need to kill for the item and the quest task will be completed.
Testing
I reproduced the bug on my own server and fixed it by applying the changes in this pull request. I have played now for 3 more levels and have completed many missions and I have not encountered any issues with the new logic.
Future
This is is merely a workaround for the bug, since it ensures that players are not stuck if the bug happens, but it is still unknown why sometimes getting all necessary items for the quest fails to complete the task.