Skip to content

Pin bindata gem to 2.5.1#231

Merged
bastelfreak merged 1 commit into
OpenVoxProject:mainfrom
Sharpie:pin-bindata
Jul 20, 2026
Merged

Pin bindata gem to 2.5.1#231
bastelfreak merged 1 commit into
OpenVoxProject:mainfrom
Sharpie:pin-bindata

Conversation

@Sharpie

@Sharpie Sharpie commented Jul 16, 2026

Copy link
Copy Markdown
Member

Short description

The bindata project just released a new 3.0 major version, but we are currently pinned to an old ruby_smb release, which depends on this gem.

Checklist

I have:

The `bindata` project just released a new 3.0 major version, but we are
currently pinned to an old `ruby_smb` release, which depends on this gem.

Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
@Sharpie

Sharpie commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

I opened this PR before really looking at OpenBolt, but now that I examine the state of automated tests over in that repo I can see that bindata 3.0 is not compatible:

/opt/hostedtoolcache/Ruby/3.2.11/x64/bin/ruby -I/home/runner/work/openbolt/openbolt/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.6/lib:/home/runner/work/openbolt/openbolt/vendor/bundle/ruby/3.2.0/gems/rspec-support-3.13.7/lib /home/runner/work/openbolt/openbolt/vendor/bundle/ruby/3.2.0/gems/rspec-core-3.13.6/exe/rspec --pattern spec/integration/\*\*/\*_spec.rb  --exclude-pattern spec/integration/transport/\* --tag apply --tag ~docker --tag ~winrm

An error occurred while loading spec_helper.
Failure/Error: require 'ruby_smb'

TypeError:
  unknown type 'extended_attribute_flag' in RubySMB::Fscc::FileFullEaInfo
# ./vendor/bundle/ruby/3.2.0/gems/ruby_smb-1.1.0/lib/ruby_smb/fscc/file_full_ea_info.rb:8:in `<class:FileFullEaInfo>'
# ./vendor/bundle/ruby/3.2.0/gems/ruby_smb-1.1.0/lib/ruby_smb/fscc/file_full_ea_info.rb:5:in `<module:Fscc>'
# ./vendor/bundle/ruby/3.2.0/gems/ruby_smb-1.1.0/lib/ruby_smb/fscc/file_full_ea_info.rb:2:in `<module:RubySMB>'
# ./vendor/bundle/ruby/3.2.0/gems/ruby_smb-1.1.0/lib/ruby_smb/fscc/file_full_ea_info.rb:1:in `<top (required)>'
# ./vendor/bundle/ruby/3.2.0/gems/ruby_smb-1.1.0/lib/ruby_smb/fscc.rb:7:in `<module:Fscc>'
# ./vendor/bundle/ruby/3.2.0/gems/ruby_smb-1.1.0/lib/ruby_smb/fscc.rb:5:in `<module:RubySMB>'
# ./vendor/bundle/ruby/3.2.0/gems/ruby_smb-1.1.0/lib/ruby_smb/fscc.rb:1:in `<top (required)>'
# ./vendor/bundle/ruby/3.2.0/gems/ruby_smb-1.1.0/lib/ruby_smb.rb:17:in `<module:RubySMB>'
# ./vendor/bundle/ruby/3.2.0/gems/ruby_smb-1.1.0/lib/ruby_smb.rb:10:in `<top (required)>'
# ./spec/spec_helper.rb:20:in `<top (required)>'
# ------------------
# --- Caused by: ---
# BinData::UnRegisteredTypeError:
#   extended_attribute_flag
#   ./vendor/bundle/ruby/3.2.0/gems/bindata-3.0.0/lib/bindata/registry.rb:61:in `lookup'
Run options:
  include {:apply=>true}
  exclude {:docker=>true, :winrm=>true}

@bastelfreak
bastelfreak merged commit 0ce8306 into OpenVoxProject:main Jul 20, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants