Skip to content

Resolved bug in the selection of particle's default z value when it is not provided by the user - #2781

Open
wyatt-fluidnumerics wants to merge 1 commit into
mainfrom
particleset-default-z
Open

Resolved bug in the selection of particle's default z value when it is not provided by the user#2781
wyatt-fluidnumerics wants to merge 1 commit into
mainfrom
particleset-default-z

Conversation

@wyatt-fluidnumerics

@wyatt-fluidnumerics wyatt-fluidnumerics commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Description

Previously the logic to initialize the depth level of particles when no depth was provided did not work as intended, and lead to the initialization of particles out of bounds. This fixes that by selected the depth level from the fields that is closest to zero.

Checklist

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.
    • Describe how you used it (e.g., by pasting your prompt): Once I had written the new logic, I had Claude Code generate a few test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

ParticleSet default initial z not set correctly (does not respect direction of depth axis)

1 participant