Adding a warning when changing data with zarr backend - #2785
Open
erikvansebille wants to merge 2 commits into
Open
Adding a warning when changing data with zarr backend#2785erikvansebille wants to merge 2 commits into
erikvansebille wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #2762, we added an option to validate field data in model.py - for example by changing land from np.nan to zero. However, this could convert a Zarr-based to a NumPy array.
This PR throws a warning when the validate_field_data function is called with a dataset that has Zarr-based variables; so that at least users know they can also create the FieldSet with
skip_field_data_validation=TrueChecklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None