Skip to content

Add quality to items fetched from trade #10072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaisest wants to merge 1 commit into
base: dev
Choose a base branch
from
+9 −18
Open

Add quality to items fetched from trade #10072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 9 additions & 18 deletions src/Classes/TradeQuery.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,27 +1030,21 @@ function TradeQueryClass:PriceItemRowDisplay(row_idx, top_pane_alignment_ref, ro
local itemsSafe = self:FilterToSafeItems(items, selectedSlot and selectedSlot.slotName)
-- replace eldritch mods or enchants if the user requested
-- so in TradeQueryGenerator
if self.tradeQueryGenerator.lastIncludeEldritch == "Copy Current" or
self.tradeQueryGenerator.lastCopyEnchantMode == "Copy Current" then
for i, _ in ipairs(itemsSafe) do
local item = new("Item", itemsSafe[i].item_string)
for i, _ in ipairs(itemsSafe) do
local item = new("Item", itemsSafe[i].item_string)
-- assume the user will add quality if they buy the item
item:NormaliseQuality()
if self.tradeQueryGenerator.lastIncludeEldritch == "Copy Current" or
self.tradeQueryGenerator.lastCopyEnchantMode == "Copy Current" then
self.itemsTab:CopyAnointsAndEldritchImplicits(item, true, true, context.slotTbl.slotName)
itemsSafe[i].item_string = item:BuildRaw()
end
elseif self.tradeQueryGenerator.lastIncludeEldritch == "Remove" then
for i, _ in ipairs(itemsSafe) do
local item = new("Item", itemsSafe[i].item_string)
elseif self.tradeQueryGenerator.lastIncludeEldritch == "Remove" then
if item.tangle or item.cleansing then
item.implicitModLines = {}
itemsSafe[i].item_string = item:BuildRaw()
end
end
elseif self.tradeQueryGenerator.lastCopyEnchantMode == "Remove" then
for i, _ in ipairs(itemsSafe) do
local item = new("Item", itemsSafe[i].item_string)
elseif self.tradeQueryGenerator.lastCopyEnchantMode == "Remove" then
item.enchantModLines = {}
itemsSafe[i].item_string = item:BuildRaw()
end
itemsSafe[i].item_string = item:BuildRaw()
end

self.resultTbl[context.row_idx] = itemsSafe
Expand Down Expand Up @@ -1215,9 +1209,6 @@ you can add them, copy the link here, and press "Price Item" to evaluate the ite
local selected_result_index = self.itemIndexTbl[row_idx]
local item_string = self.resultTbl[row_idx][selected_result_index].item_string
if selected_result_index and item_string then
-- TODO: item parsing bug caught here.
-- item.baseName is nil and throws error in the following AddItemTooltip func
-- if the item is unidentified
local item = new("Item", item_string)
local tooltipSlot = slotTbl.selectedJewelNodeId and self.itemsTab.sockets[slotTbl.selectedJewelNodeId] or activeSlot
self.itemsTab:AddItemTooltip(tooltip, item, tooltipSlot, true)
Expand Down
Loading