Skip to content

Fix internal links and standardize on npm - #180

Open
ANAMASGARD wants to merge 2 commits into
PecanProject:masterfrom
ANAMASGARD:add-eslint-internal-links-rule
Open

Fix internal links and standardize on npm#180
ANAMASGARD wants to merge 2 commits into
PecanProject:masterfrom
ANAMASGARD:add-eslint-internal-links-rule

Conversation

@ANAMASGARD

Copy link
Copy Markdown

Summary

Addresses the existing-link and npm-standardization portions of #156.

Supersedes the stale #157 branch (which would revert news→blog migration and other master changes). This PR contains only 2 commits on current master:

  1. Fix current documentation and navigation links

    • Documentation iframe fallback links match their iframe src (12 files)
    • Homepage Get Started link uses trailing slash for consistency with trailingSlash: true
  2. Remove yarn.lock and standardize on npm

    • Remove unused yarn.lock; update README for npm ci / npm run

ESLint versus Lychee

The original #157 added a custom ESLint rule. Per @dlebauer review, automated checking is deferred to #135 (Lychee) to avoid overlapping tools. This PR does not include ESLint.

Issue scope

Addresses existing-link fixes and npm standardization from #156. Automated link checking remains deferred to #135.

Does not claim to close #156 unless maintainers agree to narrow scope.

Verification

  • npm ci — exit 0, no lockfile changes
  • npm run build — exit 0
  • iframe src==href check — 12/12 OK
  • curl smoke tests on /, /documentation/latest/, /blog/, /news/ — OK

Signed-off-by: ANAMASGARD

Align documentation iframe fallback links with their embedded iframe
sources so non-iframe browsers reach the correct documentation page.

Normalize the homepage Get Started link to use a trailing slash, matching
the site's configured trailingSlash setting.

Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
Repository CI uses npm ci. Remove the unused yarn.lock file and update
README development instructions to match npm workflows.

Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ESLint rule to catch broken internal links and standardize on npm

1 participant