fix: trigger Ultra Necrozma with held Ultranecrozium Z - #1616
fix: trigger Ultra Necrozma with held Ultranecrozium Z#1616MiquelRForgeFlow wants to merge 1 commit into
Conversation
c74520c to
6641ec2
Compare
|
By the way, the |
|
It should probably just be |
Done in #1619.
Fine by me, let's think how to do it. Probably a new column in some place. Any suggestion? |
Use the existing held-item trigger + ultranecrozium-z--held (like Mega/Primal held-item transformations).
6641ec2 to
1b79fac
Compare
|
Following up on the base-form question
I'd like to propose a minimal way to cover this now, since it's the missing piece for Ultra Necrozma (and several other in-battle form changes). The problem. Proposal. Add a nullable For Ultra Necrozma this becomes two rows (same held-item trigger, one per base form): pokemon_form_id,form_trigger_id,trigger_item_id,trigger_ability_id,trigger_move_id,base_form_id
10316,1,969,,,10155 # necrozma-ultra ← necrozma-dusk-mane
10316,1,969,,,10156 # necrozma-ultra ← necrozma-dawn-wingsThe API would surface it under the existing Why a column rather than a new table. It's the same pattern Broader value. This isn't just Necrozma; it lets consumers stop heuristically guessing the base form for other in-battle changes, e.g.:
One open question: If this direction sounds good, I'll add the column, migration, loader, serializer field, and the Necrozma rows in this PR. |
Change description
Introduce a new
ultra-burst-itemform trigger and mark Ultra Necrozma as battle-only, triggered by holding Ultranecrozium Z (like Mega/Primal held-item transformations).Is distinct from
held-itemtrigger to make it easy to customize, like making it trigger from Dusk and Dawn forms instead of default form.AI coding assistance disclosure
I only asked AI to add the new
ultra-burst-item. I defined it manually in the command line, and AI added it in the code.Contributor check list