Skip to content

utest: keep testcase failures across units #11601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CYFS3 wants to merge 4 commits into
base: master
Choose a base branch
from
+125 −103
Open

utest: keep testcase failures across units #11601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
088e98b
utest: keep testcase failures across units
CYFS3 Jul 9, 2026
8269bbc
utest: stabilize CI test execution
CYFS3 Jul 14, 2026
8a6b8a6
utest: skip signal zero with musl
CYFS3 Jul 14, 2026
08b669a
style: format code with clang-format [skip ci]
Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 55 additions & 60 deletions components/net/utest/tc_netdev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ static rt_bool_t initial_dhcp_enabled; /**< Initial DHCP enable status */
*/
rt_err_t multiple_ping_test(struct netdev *netdev, const char *host, rt_uint32_t n)
{
#define UTEST_PING_DATA_LEN 32 /* Ping data packet size */
#define UTEST_PING_TIMEOUT (5 * RT_TICK_PER_SECOND) /* Ping timeout: 5 seconds */
#define UTEST_PING_DATA_LEN 32 /* Ping data packet size */
#define UTEST_PING_TIMEOUT (5 * RT_TICK_PER_SECOND) /* Ping timeout: 5 seconds */

rt_uint32_t success_num = 0, i;
rt_err_t res = RT_EOK;
Expand Down Expand Up @@ -79,47 +79,37 @@ rt_err_t multiple_ping_test(struct netdev *netdev, const char *host, rt_uint32_t
*
* This function tests network connectivity by pinging various targets:
* - Gateway address (should succeed)
* - Invalid internal IP address (should fail)
* - External IP address (should succeed)
* - Invalid external IP address (should fail)
* - External URL (should succeed)
* - Invalid external URL (should fail)
* - Invalid host name (should fail)
* - External IP address (should succeed outside CI)
* - External URL (should succeed outside CI)
*
* @note This test verifies both successful and failed ping scenarios
*/
static void test_netdev_ping(void)
{
#define UTEST_INTRANET_WRONG_IP_ADDR "192.256.0.321" /* Invalid IP format */
#define UTEST_EXTERNAL_IP_ADDR "8.8.8.8" /* Valid external IP */
#define UTEST_EXTERNAL_WRONG_IP_ADDR "123.456.789.012" /* Invalid IP format */
#define UTEST_EXTERNAL_URL "www.baidu.com" /* Valid external URL */
#define UTEST_EXTERNAL_WRONG_URL "www.abcsdd.com" /* Non-existent URL */
#define UTEST_INVALID_HOST_NAME "" /* Rejected before DNS lookup */
#define UTEST_EXTERNAL_IP_ADDR "8.8.8.8" /* Valid external IP */
#define UTEST_EXTERNAL_URL "www.baidu.com" /* Valid external URL */

rt_err_t res = RT_EOK;

/* Test ping to gateway address - should succeed */
res = multiple_ping_test(netdev_default, inet_ntoa(netdev_default->gw), 10);
uassert_true(res == RT_EOK);

/* Test ping to invalid internal IP - should fail */
res = multiple_ping_test(netdev_default, UTEST_INTRANET_WRONG_IP_ADDR, 1);
/* Test ping with an invalid host name - should fail without a DNS query */
res = multiple_ping_test(netdev_default, UTEST_INVALID_HOST_NAME, 1);
uassert_false(res == RT_EOK);

#ifndef RT_USING_CI_ACTION
/* Test ping to external IP address - should succeed */
res = multiple_ping_test(netdev_default, UTEST_EXTERNAL_IP_ADDR, 10);
uassert_true(res == RT_EOK);

/* Test ping to invalid external IP - should fail */
res = multiple_ping_test(netdev_default, UTEST_EXTERNAL_WRONG_IP_ADDR, 1);
uassert_false(res == RT_EOK);

/* Test ping to external URL - should succeed */
res = multiple_ping_test(netdev_default, UTEST_EXTERNAL_URL, 10);
uassert_true(res == RT_EOK);

/* Test ping to invalid external URL - should fail */
res = multiple_ping_test(netdev_default, UTEST_EXTERNAL_WRONG_URL, 1);
uassert_false(res == RT_EOK);
#endif
}

/**
Expand Down Expand Up @@ -170,22 +160,23 @@ static void test_netdev_netstat(void)
* @brief Test DNS server configuration and hostname resolution
*
* This function tests:
* - Setting incorrect DNS server and verifying hostname resolution fails
* - Setting correct DNS server and verifying hostname resolution succeeds
* - DNS server configuration operations
* - Setting a DNS server and verifying the configuration
* - Rejecting an out-of-range DNS server index
* - Rejecting an invalid host name without external network access
* - Hostname resolution outside CI
*
* @note DNS configuration will be restored in utest_tc_cleanup
*/
static void test_netdev_dns(void)
{
#define UTEST_DNS "114.114.114.114" /* Valid DNS server */
#define UTEST_WRONG_DNS "13.19.123.143" /* Invalid DNS server */
#define UTEST_WRONG_HOST_NAME "www.abcde.com" /* Test hostname */
#define UTEST_HOST_ADDR "www.rt-thread.org" /* RT-Thread official website */
#define UTEST_DNS "114.114.114.114" /* Valid DNS server */
#define UTEST_INVALID_HOST "" /* Rejected before DNS lookup */
#define UTEST_HOST_ADDR "www.rt-thread.org" /* RT-Thread official website */

ip_addr_t ipaddr = {0};
ip_addr_t ipaddr = { 0 };
struct hostent *res = RT_NULL;
struct sal_proto_family *netdev_inet = RT_NULL;
rt_err_t err;

/* Get SAL protocol family for DNS operations */
netdev_inet = netdev_default->sal_user_data;
Expand All @@ -196,26 +187,25 @@ static void test_netdev_dns(void)
return;
}

/* Test with wrong DNS server - hostname resolution should fail */
inet_aton(UTEST_WRONG_DNS, &ipaddr);
netdev_default->ops->set_dns_server(netdev_default, 0, &ipaddr);
netdev_default->ops->set_dns_server(netdev_default, 1, &ipaddr);
res = netdev_inet->netdb_ops->gethostbyname(UTEST_WRONG_HOST_NAME);
if (res == RT_NULL)
{
uassert_true(RT_TRUE); /* Expected failure */
}
else
{
uassert_true(RT_FALSE); /* Unexpected success */
}

/* Test with correct DNS server - hostname resolution should succeed */
/* Verify DNS server configuration without depending on a resolver response. */
inet_aton(UTEST_DNS, &ipaddr);
netdev_default->ops->set_dns_server(netdev_default, 0, &ipaddr);
netdev_default->ops->set_dns_server(netdev_default, 1, &ipaddr);
err = netdev_set_dns_server(netdev_default, 0, &ipaddr);
uassert_true(err == RT_EOK);
uassert_true(ip_addr_cmp(&netdev_default->dns_servers[0], &ipaddr));

/* An out-of-range DNS server index must be rejected. */
err = netdev_set_dns_server(netdev_default, NETDEV_DNS_SERVERS_NUM, &ipaddr);
uassert_true(err == -RT_ERROR);

/* An empty host name must be rejected locally, without a DNS query. */
res = netdev_inet->netdb_ops->gethostbyname(UTEST_INVALID_HOST);
uassert_true(res == RT_NULL);

#ifndef RT_USING_CI_ACTION
/* Test hostname resolution only outside CI. */
res = netdev_inet->netdb_ops->gethostbyname(UTEST_HOST_ADDR);
uassert_true(res != RT_NULL);
#endif

/* DNS will be restored in utest_tc_cleanup */
}
Expand Down Expand Up @@ -275,7 +265,7 @@ static void test_netdev_dhcp(void)

/* Check if IP and gateway are properly restored */
if (!ip_addr_isany(&netdev_default->ip_addr) &&
!ip_addr_isany(&netdev_default->gw))
!ip_addr_isany(&netdev_default->gw))
{
rt_kprintf("Network configuration restored after %d retries\n", retry_count);
rt_kprintf("Current IP: %s, Gateway: %s\n",
Expand Down Expand Up @@ -308,9 +298,9 @@ static void test_netdev_dhcp(void)
*/
static void test_netdev_ifconfig_set(void)
{
#define UTEST_WRONG_IP_ADDR "192.1.4.125" /* Test IP address */
#define UTEST_HOST_ADDR "www.rt-thread.org" /* Test hostname */
#define UTEST_WRONG_GW_IP_ADDR "192.168.99.1" /* Test gateway address */
#define UTEST_WRONG_IP_ADDR "192.1.4.125" /* Test IP address */
#define UTEST_HOST_ADDR "www.rt-thread.org" /* Test hostname */
#define UTEST_WRONG_GW_IP_ADDR "192.168.99.1" /* Test gateway address */

ip_addr_t ipaddr, true_ipaddr;
rt_err_t res = RT_EOK;
Expand Down Expand Up @@ -406,9 +396,9 @@ static void test_netdev_set_default_netdev(void)
*/
static void test_netdev_ipaddr_conversion(void)
{
#define UTEST_IP4_ADDR_STR "192.168.1.1" /* Valid IPv4 address */
#define UTEST_IP4_ADDR_STR2 "10.0.0.1" /* Another valid IPv4 address */
#define UTEST_INVALID_IP_STR "999.999.999.999" /* Invalid IPv4 address */
#define UTEST_IP4_ADDR_STR "192.168.1.1" /* Valid IPv4 address */
#define UTEST_IP4_ADDR_STR2 "10.0.0.1" /* Another valid IPv4 address */
#define UTEST_INVALID_IP_STR "999.999.999.999" /* Invalid IPv4 address */

ip4_addr_t ip4_addr;
char buf[16]; /* Maximum length for IPv4 string representation */
Expand Down Expand Up @@ -584,7 +574,7 @@ static void test_netdev_config_set(void)
ip_addr_t original_netmask = netdev_default->netmask;
ip_addr_t original_dns0 = netdev_default->dns_servers[0];
ip_addr_t original_dns1 = netdev_default->dns_servers[1];
ip_addr_t test_netmask = {0}, test_dns = {0};
ip_addr_t test_netmask = { 0 }, test_dns = { 0 };
rt_err_t res;

/* Test set_netmask */
Expand Down Expand Up @@ -1064,19 +1054,24 @@ static rt_err_t utest_tc_cleanup(void)

/* Restore network configuration */
res = netdev_set_ipaddr(netdev_default, &initial_ip_addr);
if (res != RT_EOK) rt_kprintf("Warning: Failed to restore IP address: %d\n", res);
if (res != RT_EOK)
rt_kprintf("Warning: Failed to restore IP address: %d\n", res);

res = netdev_set_netmask(netdev_default, &initial_netmask);
if (res != RT_EOK) rt_kprintf("Warning: Failed to restore netmask: %d\n", res);
if (res != RT_EOK)
rt_kprintf("Warning: Failed to restore netmask: %d\n", res);

res = netdev_set_gw(netdev_default, &initial_gw);
if (res != RT_EOK) rt_kprintf("Warning: Failed to restore gateway: %d\n", res);
if (res != RT_EOK)
rt_kprintf("Warning: Failed to restore gateway: %d\n", res);

res = netdev_set_dns_server(netdev_default, 0, &initial_dns0);
if (res != RT_EOK) rt_kprintf("Warning: Failed to restore DNS0: %d\n", res);
if (res != RT_EOK)
rt_kprintf("Warning: Failed to restore DNS0: %d\n", res);

res = netdev_set_dns_server(netdev_default, 1, &initial_dns1);
if (res != RT_EOK) rt_kprintf("Warning: Failed to restore DNS1: %d\n", res);
if (res != RT_EOK)
rt_kprintf("Warning: Failed to restore DNS1: %d\n", res);

/* Restore DHCP state */
if (initial_dhcp_enabled)
Expand Down
Loading