Skip to content

Make handleError defensive - #1561

Open
cocomarine wants to merge 5 commits into
mainfrom
1652-handle-non-standard-p5-exceptions
Open

Make handleError defensive#1561
cocomarine wants to merge 5 commits into
mainfrom
1652-handle-non-standard-p5-exceptions

Conversation

@cocomarine

@cocomarine cocomarine commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Closes https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1652

There are two problems compounding: (1) some p5/py5 call throws a non-standard exception, and (2) the error handler isn't defensive enough to report it safely, so it crashes instead of showing the user a normal error message.

Generated with the help of Claude

@cocomarine
cocomarine temporarily deployed to previews/1561/merge July 29, 2026 11:46 — with GitHub Actions Inactive
@cocomarine cocomarine changed the title Cater for non-standard exception and make handleError defensive Make handleError defensive Jul 29, 2026
@cocomarine
cocomarine temporarily deployed to previews/1561/merge July 29, 2026 13:40 — with GitHub Actions Inactive
@cocomarine
cocomarine marked this pull request as ready for review July 29, 2026 14:26
@cocomarine
cocomarine temporarily deployed to previews/1561/merge July 31, 2026 10:05 — with GitHub Actions Inactive

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d4385cc. Configure here.

Comment thread src/components/Editor/Runners/PythonRunner/SkulptRunner/SkulptRunner.jsx Outdated
@cocomarine
cocomarine temporarily deployed to previews/1561/merge July 31, 2026 12:58 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant