Skip to content

Issue 272 fixed: 4.4 variable name - #273

Open
habibasorour wants to merge 1 commit into
RunestoneInteractive:masterfrom
habibasorour:issue_272_typo
Open

Issue 272 fixed: 4.4 variable name#273
habibasorour wants to merge 1 commit into
RunestoneInteractive:masterfrom
habibasorour:issue_272_typo

Conversation

@habibasorour

Copy link
Copy Markdown
Contributor

Description

fixed a variable

Issue Fix

fixes #272

Screenshot

image

Tested

Local Build

@pearcej
pearcej marked this pull request as ready for review July 29, 2026 19:19
@pearcej

pearcej commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

@habibasorour is it running now?

@habibasorour

Copy link
Copy Markdown
Contributor Author

@pearcej unfortunately still no
image

@pearcej pearcej left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@habibasorour If it is not running still, please change to if/elif/else. Broken code should not remain.

@habibasorour

Copy link
Copy Markdown
Contributor Author

@pearcej
Do I just not make it active code and leave it as it was?
There is a subsection about else if with the same goal (grader program) earlier in 4.3

@pearcej

pearcej commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

No, broken code should be removed. You can combine the sections.

@habibasorour

Copy link
Copy Markdown
Contributor Author

@pearcej there is an issue about combining all of the conditional sections into one, I will fix it with that.

I am confused about why the code is not running, I tried an online compiler that runs newer python and it ran smoothly.
image

online compiler: https://www.jdoodle.com/python3-programming-online

@pearcej

pearcej commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

@habibasorour Likely, that particular structure is not available. Not all on-line python is the same. Runestone always you to step backwards as well as just run and that is complicated.

@bnmnetp

bnmnetp commented Jul 29, 2026

Copy link
Copy Markdown
Member

I can confirm that match has not been added to skulpt. The whole patttern matching thing is pretty complex and I would not want to try to teach it to new programmers. I can see that you are trying to mimic a case statement, which is a valid use, but that is only the tip of the iceberg.

@pearcej

pearcej commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

@habibasorour Can you please message me if you have questions or commit to this branch with fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.4.2: fix variable

3 participants