Skip to content

Improvements to Peer InstructionI User Interface - #1327

Open
sethbern wants to merge 5 commits into
RunestoneInteractive:mainfrom
sethbern:peer-instruction-ui
Open

Improvements to Peer InstructionI User Interface#1327
sethbern wants to merge 5 commits into
RunestoneInteractive:mainfrom
sethbern:peer-instruction-ui

Conversation

@sethbern

Copy link
Copy Markdown
Contributor

This improves the peer instruction user interface in a few places:

  • When viewing saved student justifications in async PI, it now should only 4 student responses shown at random with a show-more button, plus an AI summary when the course has an API key
  • Merge the justification and LLM chat tabs into one conversation
  • In synchronous PI, show separate per-vote answer counts so vote 1's total stays put
    once vote 2 begins so instructors can easily compare response counts across different votes
  • Fix generated analogies ignoring the student's chosen theme and over fitting to the system prompt
  • Fix justifications being saved with extra wrapper text instead of just the student's answer

@sethbern
sethbern requested a review from bnmnetp as a code owner July 29, 2026 13:32
@sethbern

Copy link
Copy Markdown
Contributor Author

Hey @bnmnetp, I ran black and ruff locally and they both pass, is it possible that it is failing the tests from code outside this pr?

@bnmnetp

bnmnetp commented Jul 29, 2026

Copy link
Copy Markdown
Member

Passing for me locally as well. It may be a new version of ruff is catching new things... I'll look into it.

@bnmnetp

bnmnetp commented Jul 29, 2026

Copy link
Copy Markdown
Member

I'm assuming you are fully up to date with runestone main?

@sethbern

Copy link
Copy Markdown
Contributor Author

@bnmnetp I think I was behind on a few commits from the past day or two but after syncing with main it still does not pass

@bnmnetp

bnmnetp commented Jul 29, 2026

Copy link
Copy Markdown
Member

Yeah, it looks like the automated CI is running ruff 0.16 whereas our pyproject.toml file has it pinned to < 0.16

@bnmnetp

bnmnetp commented Jul 29, 2026

Copy link
Copy Markdown
Member

Just pushed a change to the workflow to pin the version of ruff to 0.15.x so try to rebase and push again.

@sethbern

Copy link
Copy Markdown
Contributor Author

Lint's fixed now, thanks! crud-tests is still failing but it looks like it's in the install step before any tests run, something with pycairo not building on the runner. Tests pass for me locally though

@bnmnetp

bnmnetp commented Jul 29, 2026

Copy link
Copy Markdown
Member

OK, the crud-test install has been fixed, one more rebase and hopefully this will pass on CI as well as locally.

Thanks.

@sethbern

Copy link
Copy Markdown
Contributor Author

Everything seems to be passing now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants