Improvements to Peer InstructionI User Interface - #1327
Conversation
|
Hey @bnmnetp, I ran black and ruff locally and they both pass, is it possible that it is failing the tests from code outside this pr? |
|
Passing for me locally as well. It may be a new version of ruff is catching new things... I'll look into it. |
|
I'm assuming you are fully up to date with runestone main? |
|
@bnmnetp I think I was behind on a few commits from the past day or two but after syncing with main it still does not pass |
|
Yeah, it looks like the automated CI is running ruff 0.16 whereas our pyproject.toml file has it pinned to < 0.16 |
|
Just pushed a change to the workflow to pin the version of ruff to 0.15.x so try to rebase and push again. |
|
Lint's fixed now, thanks! crud-tests is still failing but it looks like it's in the install step before any tests run, something with pycairo not building on the runner. Tests pass for me locally though |
|
OK, the crud-test install has been fixed, one more rebase and hopefully this will pass on CI as well as locally. Thanks. |
|
Everything seems to be passing now, thanks! |
This improves the peer instruction user interface in a few places:
once vote 2 begins so instructors can easily compare response counts across different votes