Add support for delaying window creation until parent is set - #303
Merged
Conversation
prokopyl
changed the title
prokopyl
marked this pull request as ready for review
July 28, 2026 22:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some APIs (notably the CLAP GUI API) only provide the parent window until after the window creation completes. However, turning the underlying window from non-parented to parented can cause issues on some platforms.
This PR adds the
WindowSettings::parentedoption, which instructsbaseviewto delay window creation until the firstset_parentcall, while still allowing to query and make changes to the window (which will be applied at window creation).