Add store delete command#8035
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
alfonso-noriega
marked this pull request as ready for review
July 8, 2026 11:09
|
This has been NEEDED! |
isaacroldan
reviewed
Jul 9, 2026
isaacroldan
reviewed
Jul 9, 2026
alfonso-noriega
force-pushed
the
store-delete-dev
branch
from
July 9, 2026 14:09
c4ddb40 to
274afea
Compare
isaacroldan
approved these changes
Jul 9, 2026
alfonso-noriega
force-pushed
the
store-delete-dev
branch
from
July 13, 2026 10:17
274afea to
f110d2c
Compare
Contributor
Author
|
/snapit |
1 similar comment
Contributor
Author
|
/snapit |
alfonso-noriega
force-pushed
the
store-delete-dev
branch
2 times, most recently
from
July 16, 2026 13:35
437d91f to
11125b5
Compare
isaacroldan
reviewed
Jul 16, 2026
isaacroldan
reviewed
Jul 16, 2026
isaacroldan
reviewed
Jul 16, 2026
isaacroldan
reviewed
Jul 16, 2026
isaacroldan
left a comment
Contributor
There was a problem hiding this comment.
Review assisted by pair-review
alfonso-noriega
force-pushed
the
store-delete-dev
branch
2 times, most recently
from
July 16, 2026 16:22
56031ae to
638480a
Compare
alfonso-noriega
force-pushed
the
store-delete-dev
branch
2 times, most recently
from
July 16, 2026 16:35
155cf63 to
690aecd
Compare
Assisted-By: devx/921acb10-d127-42c8-8a9a-0314a325d188
alfonso-noriega
force-pushed
the
store-delete-dev
branch
from
July 16, 2026 16:57
690aecd to
761c62d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Fixes https://github.com/shop/issues-develop/issues/22936
Shopify CLI needs a CLI-side
shopify store deletecommand for app development stores. Business Platform now accepts app development store deletion requests by calling CorebillingCloseShop(immediate: true), but Core cancellation completes asynchronously and BP no longer eagerly removes the BP Shop row. Because mutation success means “close request accepted”, the CLI must wait for the authoritative cancellation signal from Organizations API instead of treating row disappearance as success.WHAT is this pull request doing?
shopify store deletecommand in@shopify/storefor deleting development stores.--json,--store, and--organization-id.deleteAppDevelopmentStoreBusiness Platform mutation document and typed document.shopifyShopIdusing the existing Organizations API accessible shops lookup before polling.organization.accessibleShop(id:)untilplanNameis exactlycancelled.accessibleShopresponse as inconclusive rather than confirmed cancellation.accessibleShoppolling responses.How to test your changes?
pnpm --filter @shopify/store vitest run src/cli/commands/store/delete.test.ts src/cli/services/store/delete/dev.test.ts src/cli/services/store/info/organization-shop.test.tspnpm --filter @shopify/store lintpnpm --filter @shopify/store type-checkPost-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add